| commit | 1d7a637340ea097ea55061af7b566ceccc2678c8 | [log] [tgz] |
|---|---|---|
| author | Taylor Brandstetter <deadbeef@webrtc.org> | Wed Aug 24 20:15:27 2016 |
| committer | Taylor Brandstetter <deadbeef@webrtc.org> | Wed Aug 24 20:15:35 2016 |
| tree | cf12e79aa71177b6f0ec538102620a29f48e042b | |
| parent | fcada904857e066a202e5f4cff92cb9c4de8fca4 [diff] |
Fixing off-by-one error with max SCTP id. Normally, when creating a data channel with an out-of-range ID, createDataChannel returns nullptr. But due to an off-by-one error, creating a data channel with ID 1023 returns a data channel that silently fails later. This probably occurred because it wasn't clear whether "kMaxSctpSid" was an inclusive or exclusive maximum, so I changed the value to "kMaxSctpStreams". This wasn't caught by unit tests because the off-by-one error persisted to the unit tests as well. Also getting rid of some dead code. We were adding SCTP streams to the ContentDescription object but they weren't being used. BUG=619849 R=pthatcher@webrtc.org, skvlad@webrtc.org Review URL: https://codereview.webrtc.org/2254003002 . Cr-Commit-Position: refs/heads/master@{#13906}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.