commit 1dcb16409a3e82518ef852ec5614f87dff04f248
author deadbeef <deadbeef@webrtc.org> Thu Mar 30 04:08:16 2017
committer Commit bot <commit-bot@chromium.org> Thu Mar 30 04:08:16 2017
tree a38ff558805bfc77bb7795aedb9ffadb76a128ec
parent 7735b1e932b439041238c1b68ae24d0529ba6828

Rewrite PeerConnection integration tests using better testing practices.

Also renames "peerconnection_unittests" to "peerconnection_integrationtests",
and moves the ICE URL parsing code to separate files.

The main problem previously was that the test assertions
occurred in various places in the main test class, and this shared test
code was overly complex and stateful. As a result, it was difficult to
tell what a test even does, let alone what assertions it's meant to be
making. And writing a new test that does what you want can be a
frustrating ordeal.

The new code still uses helper methods, but they have intuitive names
and a smaller role; all of the important parts of the test's logic are
in the test case itself.

We're planning on merging PeerConnection and WebRtcSession at some point
soon, so it seemed valuable to do this, so that the WebRtcSession tests
can be rewritten as PeerConnection tests using better patterns.

BUG=None

Review-Url: https://codereview.webrtc.org/2738353003
Cr-Commit-Position: refs/heads/master@{#17458}