commit 209a44830737f94879295c085bd18b8adcdd502c
author Henrik Boström <hbos@webrtc.org> Thu Apr 06 11:29:55 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Apr 06 11:30:37 2023
tree 591ecf66dfb9626249332ebe1e1e589cd0a8fe2c
parent ba5f633a94de22b2bccd49c36344511e65161064

Revert "Don't call EXPECT_TRUE_WAIT recursively."

This reverts commit d0dfe95bf082df7c38b24c8d20da91339f5199e5.

Reason for revert: It didn't help

Original change's description:
> Don't call EXPECT_TRUE_WAIT recursively.
>
> In case this triggers unexpected error handling on ASAN.
>
> Bug: webrtc:15018
> Change-Id: Iec8154081f3831ee60902bb94900d79a98ea01fa
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/300480
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Commit-Queue: Henrik Boström <hbos@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#39779}

Bug: webrtc:15018
Change-Id: I3b6e2434e2c88719ebf9f32c9d9a4dd1c21178a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/300482
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39781}

pc/peer_connection_simulcast_unittest.cc

diff --git a/pc/peer_connection_simulcast_unittest.cc b/pc/peer_connection_simulcast_unittest.cc
index f61d1e0..f975d37 100644
--- a/pc/peer_connection_simulcast_unittest.cc
+++ b/pc/peer_connection_simulcast_unittest.cc
@@ -986,10 +986,7 @@
       rtc::scoped_refptr<PeerConnectionTestWrapper> pc_wrapper) {
     auto callback = rtc::make_ref_counted<MockRTCStatsCollectorCallback>();
     pc_wrapper->pc()->GetStats(callback.get());
-    while (!callback->called()) {
-      rtc::Thread::Current()->ProcessMessages(0);
-      rtc::Thread::Current()->SleepMs(1);
-    }
+    EXPECT_TRUE_WAIT(callback->called(), kDefaultTimeout.ms());
     return callback->report();
   }