commit 20e4c80fbefb1cbfd6756a03cdb19d887bf98079
author Mirko Bonadei <mbonadei@webrtc.org> Mon Nov 23 10:07:42 2020
committer Commit Bot <commit-bot@chromium.org> Mon Nov 23 11:29:36 2020
tree 0a5b48a154dfe9356b439b61d0c4dbb1be92988d
parent cf1308fddd9974a1fdf5f9d2fb03e93af69b6d1b

Reland "Introduce RTC_NO_UNIQUE_ADDRESS."

This is a reland of f5e261aaf65cdf2eb903cdf40d651846be44f447

This CL disables RTC_NO_UNIQUE_ADDRESS on MSan builds since
there have been some issues.

Original change's description:
> Introduce RTC_NO_UNIQUE_ADDRESS.
>
> This macro introduces the possibility to suggest the compiler that a
> data member doesn't need an address different from other non static
> data members.
>
> The usage of a macro is to maintain portability since at the moment
> the attribute [[no_unique_address]] is only supported by clang
> with at least -std=c++11 but it should be supported by all the
> compilers starting from C++20.
>
> Bug: webrtc:11495
> Change-Id: I9f12b67b4422a2749649eaa6b004a67d5fd572d8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173331
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32246}

Bug: webrtc:11495, webrtc:12218
Change-Id: I4e6c7cc37d3daffad2407c9a2acfa897fa5b426a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189968
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32668}

pc/BUILD.gn

diff --git a/pc/BUILD.gn b/pc/BUILD.gn
index 84aba07..143ce25 100644
--- a/pc/BUILD.gn
+++ b/pc/BUILD.gn
@@ -286,6 +286,7 @@
     "../rtc_base/synchronization:mutex",
     "../rtc_base/synchronization:sequence_checker",
     "../rtc_base/system:file_wrapper",
+    "../rtc_base/system:no_unique_address",
     "../rtc_base/system:rtc_export",
     "../rtc_base/task_utils:pending_task_safety_flag",
     "../rtc_base/task_utils:to_queued_task",
@@ -515,6 +516,7 @@
     "../media:rtc_media_base",
     "../rtc_base",
     "../rtc_base/synchronization:mutex",
+    "../rtc_base/system:no_unique_address",
   ]
 }
 

pc/video_rtp_track_source.h

diff --git a/pc/video_rtp_track_source.h b/pc/video_rtp_track_source.h
index b887849..9903aaa 100644
--- a/pc/video_rtp_track_source.h
+++ b/pc/video_rtp_track_source.h
@@ -17,6 +17,7 @@
 #include "pc/video_track_source.h"
 #include "rtc_base/callback.h"
 #include "rtc_base/synchronization/mutex.h"
+#include "rtc_base/system/no_unique_address.h"
 
 namespace webrtc {
 
@@ -67,7 +68,7 @@
       rtc::VideoSinkInterface<RecordableEncodedFrame>* sink) override;
 
  private:
-  SequenceChecker worker_sequence_checker_;
+  RTC_NO_UNIQUE_ADDRESS SequenceChecker worker_sequence_checker_;
   // |broadcaster_| is needed since the decoder can only handle one sink.
   // It might be better if the decoder can handle multiple sinks and consider
   // the VideoSinkWants.