commit 23e684c8d32bb2b98f3a620d75b5e01afebae568
author Tommi <tommi@webrtc.org> Sat Sep 27 12:27:12 2025
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 29 21:05:13 2025
tree 613aaa186f88cb92e96474690dce2de5e5c574a3
parent 5d3b06bd1a1f16bd4b7d6d91951b74f270dcea1b

Move candidate-attribute logic to the Candidate class

Introduce a new method, `Candidate::ToCandidateAttribute`, to handle
the serialization of a Candidate object into the SDP
'candidate-attribute' string format defined in RFC 5245.

This change is the first step in breaking a circular dependency
between the 'api' target (which contains `Candidate`) and the
'webrtc_sdp' target. Previously, 'api' relied on serialization
functions within 'webrtc_sdp', which in turn depended on 'api'.
By moving this logic into the `Candidate` class itself, 'api' no
longer needs 'webrtc_sdp' for this functionality.

This CL copies the existing logic from `pc/webrtc_sdp.cc` into
`api/candidate.cc` and adds `RTC_DCHECK` assertions to verify that
the new method produces output identical to the old logic. The
old code paths will be removed in a subsequent change.

Bug: webrtc:12330
Change-Id: I5a950e2d131c0ee1400091e454823f67070f730e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/411040
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45768}