commit 24992e95183d4c5a853b6e791485851a0cf55cbd
author Harald Alvestrand <hta@webrtc.org> Fri Nov 22 10:04:05 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Nov 22 11:13:47 2024
tree ed6082abb25ff114ccf58512ede06b92ea3cd88e
parent 394da76a9c9d8959049a202f5db0c209c176d8c6

Report all usage patterns to UKM

This stores usage for all cases, making it easier to discover
abusive usages on unexpected patterns.

Bug: None
Change-Id: I62c9b07498e811ac04c221f57cfbc02312aaaacc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/368902
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43442}

pc/usage_pattern.cc

diff --git a/pc/usage_pattern.cc b/pc/usage_pattern.cc
index 8484721..e96a394 100644
--- a/pc/usage_pattern.cc
+++ b/pc/usage_pattern.cc
@@ -25,24 +25,14 @@
   RTC_HISTOGRAM_ENUMERATION_SPARSE("WebRTC.PeerConnection.UsagePattern",
                                    usage_event_accumulator_,
                                    static_cast<int>(UsageEvent::MAX_VALUE));
-  const int bad_bits =
-      static_cast<int>(UsageEvent::SET_LOCAL_DESCRIPTION_SUCCEEDED) |
-      static_cast<int>(UsageEvent::CANDIDATE_COLLECTED);
-  const int good_bits =
-      static_cast<int>(UsageEvent::SET_REMOTE_DESCRIPTION_SUCCEEDED) |
-      static_cast<int>(UsageEvent::REMOTE_CANDIDATE_ADDED) |
-      static_cast<int>(UsageEvent::ICE_STATE_CONNECTED);
-  if ((usage_event_accumulator_ & bad_bits) == bad_bits &&
-      (usage_event_accumulator_ & good_bits) == 0) {
-    // If called after close(), we can't report, because observer may have
-    // been deallocated, and therefore pointer is null. Write to log instead.
-    if (observer) {
-      observer->OnInterestingUsage(usage_event_accumulator_);
-    } else {
-      RTC_LOG(LS_INFO) << "Interesting usage signature "
-                       << usage_event_accumulator_
-                       << " observed after observer shutdown";
-    }
+  // If called after close(), we can't report, because observer may have
+  // been deallocated, and therefore pointer is null. Write to log instead.
+  if (observer) {
+    observer->OnInterestingUsage(usage_event_accumulator_);
+  } else {
+    RTC_LOG(LS_INFO) << "Interesting usage signature "
+                     << usage_event_accumulator_
+                     << " observed after observer shutdown";
   }
 }