commit 26cfc77cc25366a8e5f0be33d311211a38e792ad
author Danil Chapovalov <danilchap@webrtc.org> Mon Jun 30 11:34:25 2025
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 30 15:37:15 2025
tree 1264c7bf30adc969657ab45ab57198468199614e
parent 4690e0b758acf196e0ed810b6cde77c3ca74e437

Do not set global field trials string in video loopback tools.

This tools rely on VideoQualityTest fixture that was migrated to use
propagated field trials that are populated from the same command line
flag. Setting global field trials string has no effect and is no longer
needed.

Bug: webrtc:419453427
Change-Id: Ida7e55c771456f33894d98c6bff318a7dfbe1a78
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398501
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45048}

video/BUILD.gn

diff --git a/video/BUILD.gn b/video/BUILD.gn
index 044a89e..c1acd56 100644
--- a/video/BUILD.gn
+++ b/video/BUILD.gn
@@ -724,11 +724,9 @@
         "../api/video_codecs:video_codecs_api",
         "../rtc_base:checks",
         "../rtc_base:logging",
-        "../system_wrappers:field_trial",
         "../test:run_test",
         "../test:run_test_interface",
         "../test:test_common",
-        "../test:test_flags",
         "../test:test_renderer",
         "../test:test_support",
         "//testing/gtest",
@@ -767,11 +765,9 @@
         "../rtc_base:checks",
         "../rtc_base:logging",
         "../rtc_base:stringutils",
-        "../system_wrappers:field_trial",
         "../test:run_test",
         "../test:run_test_interface",
         "../test:test_common",
-        "../test:test_flags",
         "../test:test_renderer",
         "../test:test_support",
         "//third_party/abseil-cpp/absl/flags:flag",
@@ -793,11 +789,9 @@
         "../rtc_base:checks",
         "../rtc_base:logging",
         "../rtc_base:stringutils",
-        "../system_wrappers:field_trial",
         "../test:run_test",
         "../test:run_test_interface",
         "../test:test_common",
-        "../test:test_flags",
         "../test:test_renderer",
         "../test:test_support",
         "//testing/gtest",

video/screenshare_loopback.cc

diff --git a/video/screenshare_loopback.cc b/video/screenshare_loopback.cc
index cc78ee9..c2a2f16 100644
--- a/video/screenshare_loopback.cc
+++ b/video/screenshare_loopback.cc
@@ -25,10 +25,8 @@
 #include "rtc_base/checks.h"
 #include "rtc_base/logging.h"
 #include "rtc_base/string_encode.h"
-#include "system_wrappers/include/field_trial.h"
 #include "test/gtest.h"
 #include "test/run_test.h"
-#include "test/test_flags.h"
 #include "video/video_quality_test.h"
 
 using ::webrtc::BitrateConstraints;
@@ -384,11 +382,6 @@
 
   webrtc::LogMessage::SetLogToStderr(absl::GetFlag(FLAGS_logs));
 
-  // InitFieldTrialsFromString stores the char*, so the char array must outlive
-  // the application.
-  const std::string field_trials = absl::GetFlag(FLAGS_force_fieldtrials);
-  webrtc::field_trial::InitFieldTrialsFromString(field_trials.c_str());
-
   webrtc::test::RunTest(Loopback);
   return 0;
 }

video/sv_loopback.cc

diff --git a/video/sv_loopback.cc b/video/sv_loopback.cc
index 8f0f457..3af3b69 100644
--- a/video/sv_loopback.cc
+++ b/video/sv_loopback.cc
@@ -24,10 +24,8 @@
 #include "rtc_base/checks.h"
 #include "rtc_base/logging.h"
 #include "rtc_base/string_encode.h"
-#include "system_wrappers/include/field_trial.h"
 #include "test/gtest.h"
 #include "test/run_test.h"
-#include "test/test_flags.h"
 #include "video/video_quality_test.h"
 
 // Flags for video.
@@ -703,11 +701,6 @@
 
   webrtc::LogMessage::SetLogToStderr(absl::GetFlag(FLAGS_logs));
 
-  // InitFieldTrialsFromString stores the char*, so the char array must outlive
-  // the application.
-  const std::string field_trials = absl::GetFlag(FLAGS_force_fieldtrials);
-  webrtc::field_trial::InitFieldTrialsFromString(field_trials.c_str());
-
   webrtc::test::RunTest(webrtc::Loopback);
   return 0;
 }

video/video_loopback.cc

diff --git a/video/video_loopback.cc b/video/video_loopback.cc
index bee8b0c..4c83f1a 100644
--- a/video/video_loopback.cc
+++ b/video/video_loopback.cc
@@ -24,10 +24,8 @@
 #include "api/video_codecs/video_codec.h"
 #include "rtc_base/checks.h"
 #include "rtc_base/logging.h"
-#include "system_wrappers/include/field_trial.h"
 #include "test/gtest.h"
 #include "test/run_test.h"
-#include "test/test_flags.h"
 #include "video/video_quality_test.h"
 
 // Flags common with screenshare loopback, with different default values.
@@ -438,11 +436,6 @@
 
   LogMessage::SetLogToStderr(absl::GetFlag(FLAGS_logs));
 
-  // InitFieldTrialsFromString stores the char*, so the char array must outlive
-  // the application.
-  const std::string field_trials = absl::GetFlag(FLAGS_force_fieldtrials);
-  field_trial::InitFieldTrialsFromString(field_trials.c_str());
-
   test::RunTest(Loopback);
   return 0;
 }