| commit | 2979f55f95ec71425a32fca31c50c9cbd71ad738 | [log] [tgz] |
|---|---|---|
| author | henrik.lundin <henrik.lundin@webrtc.org> | Fri May 05 12:04:16 2017 |
| committer | Commit bot <commit-bot@chromium.org> | Fri May 05 12:04:16 2017 |
| tree | 8e63fa309bc3217ba668b4dbad8eb301a1884ada | |
| parent | 2a28035627ab93463005d9549b2f47db6600aa69 [diff] |
NetEq: Fix a bug in expand_rate and speech_expand_rate calculation After a Merge operation, the statistics for number of samples generated using Expand must be corrected, and the correction can in fact be negative. However, a bug was introduced in https://codereview.webrtc.org/1230503003 which uses a size_t to represent the correction, which leads to wrap-around of the negative value. This is not a problem in itself, since this value is added to another size_t, with the effect that the desired subtraction happens anyway. The actual problem arises if the statistics are polled/reset before a subtraction happens -- that is, between an Expand and a Merge operation. This will lead to an actual wrap-around of the stats value, and large expand_rate (16384) is reported. BUG=webrtc:7554 Review-Url: https://codereview.webrtc.org/2859483005 Cr-Commit-Position: refs/heads/master@{#18029}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.