commit | 29ffdc1a15e31bd81e806ff135c2100d811714f0 | [log] [tgz] |
---|---|---|
author | deadbeef <deadbeef@webrtc.org> | Fri Feb 12 20:00:42 2016 |
committer | Commit bot <commit-bot@chromium.org> | Fri Feb 12 20:00:47 2016 |
tree | b82cd83d11b2fa925deadaaaf8287e91c19fa721 | |
parent | 5e7834e151c15d9f28a5faa9683a1b5c26bacaef [diff] |
Revert of Don't send FEC for H.264 with NACK enabled. (patchset #5 id:80001 of https://codereview.webrtc.org/1687303002/ ) Reason for revert: Broke the VerifyHistogramStatsWithRed test on the Windows DrMemory Full bot and Linux Memcheck bot. Please fix the test and reland. Original issue's description: > Don't send FEC for H.264 with NACK enabled. > > The H.264 does not contain picture IDs and are not sufficient to > determine that a packet may be skipped. This causes retransmission > requests for FEC that are currently dropped by the sender (since they > should be redundant). > > The receiver is then unable to continue without having the packet gap > filled (unlike VP8/VP9 which moves on since it has a consecutive stream > of picture IDs). > > Even if FEC retransmission did work it's a huge waste of bandwidth, > since it just adds additional overhead that has to be unconditionally > transmitted. This bandwidth is better used to send higher-quality > frames. > > BUG=webrtc:5264 > R=stefan@webrtc.org > > Committed: https://crrev.com/25558ad819b4df41ba51537e26a77480ace1e525 > Cr-Commit-Position: refs/heads/master@{#11601} TBR=stefan@webrtc.org,pbos@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5264 Review URL: https://codereview.webrtc.org/1692783005 Cr-Commit-Position: refs/heads/master@{#11607}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.