Use backticks not vertical bars to denote variables in comments for /p2p
Bug: webrtc:12338
Change-Id: Ie047b750cdf7ea2efe7a4632d18d5ed719c5ea83
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226952
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34570}
diff --git a/p2p/base/basic_ice_controller.cc b/p2p/base/basic_ice_controller.cc
index aa20025..dca04ca 100644
--- a/p2p/base/basic_ice_controller.cc
+++ b/p2p/base/basic_ice_controller.cc
@@ -339,7 +339,7 @@
}
// During the initial state when nothing has been pinged yet, return the first
- // one in the ordered |connections_|.
+ // one in the ordered `connections_`.
auto connections = connections_;
return *(std::find_if(connections.begin(), connections.end(),
[conn1, conn2](const Connection* conn) {
@@ -382,7 +382,7 @@
std::map<const rtc::Network*, const Connection*>
BasicIceController::GetBestConnectionByNetwork() const {
- // |connections_| has been sorted, so the first one in the list on a given
+ // `connections_` has been sorted, so the first one in the list on a given
// network is the best connection on the network, except that the selected
// connection is always the best connection on the network.
std::map<const rtc::Network*, const Connection*> best_connection_by_network;
@@ -390,7 +390,7 @@
best_connection_by_network[selected_connection_->network()] =
selected_connection_;
}
- // TODO(honghaiz): Need to update this if |connections_| are not sorted.
+ // TODO(honghaiz): Need to update this if `connections_` are not sorted.
for (const Connection* conn : connections_) {
const rtc::Network* network = conn->network();
// This only inserts when the network does not exist in the map.
@@ -645,7 +645,7 @@
}
// Compares two connections based only on the candidate and network information.
-// Returns positive if |a| is better than |b|.
+// Returns positive if `a` is better than `b`.
int BasicIceController::CompareConnectionCandidates(const Connection* a,
const Connection* b) const {
int compare_a_b_by_networks =
@@ -758,7 +758,7 @@
// which point, we would prune out the current selected connection). We leave
// connections on other networks because they may not be using the same
// resources and they may represent very distinct paths over which we can
- // switch. If |best_conn_on_network| is not connected, we may be reconnecting
+ // switch. If `best_conn_on_network` is not connected, we may be reconnecting
// a TCP connection and should not prune connections in this network.
// See the big comment in CompareConnectionStates.
//
@@ -804,13 +804,13 @@
case NominationMode::SEMI_AGGRESSIVE: {
// Nominate if
// a) Remote is in FULL ICE AND
- // a.1) |conn| is the selected connection OR
+ // a.1) `conn` is the selected connection OR
// a.2) there is no selected connection OR
// a.3) the selected connection is unwritable OR
- // a.4) |conn| has higher priority than selected_connection.
+ // a.4) `conn` has higher priority than selected_connection.
// b) Remote is in LITE ICE AND
- // b.1) |conn| is the selected_connection AND
- // b.2) |conn| is writable.
+ // b.1) `conn` is the selected_connection AND
+ // b.2) `conn` is writable.
bool selected = conn == selected_connection_;
if (remote_ice_mode == ICEMODE_LITE) {
return selected && conn->writable();
