commit 2eb465fc7b9c36e981973d0b2ea1d29c3d28d95d
author Niels Möller <nisse@webrtc.org> Mon Aug 23 09:17:56 2021
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Aug 24 06:55:17 2021
tree ef47c1f277c28c0be020610f42c0568686e556b1
parent 8fa5e65818f5d4a4b1d9b4b3bf3dae0b94c87184

Log error on ssltcp failures (fake ssl handshake)

Followup to https://webrtc-review.googlesource.com/c/src/+/229384.

Bug: None
Change-Id: I9d0a4f29514b5699f90e9a8af1457a7b68de3bd0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229586
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#34833}

rtc_base/socket_adapters.cc

diff --git a/rtc_base/socket_adapters.cc b/rtc_base/socket_adapters.cc
index cc541a4..ee8ec87 100644
--- a/rtc_base/socket_adapters.cc
+++ b/rtc_base/socket_adapters.cc
@@ -183,6 +183,7 @@
   // TODO: we could buffer output too...
   const int res = DirectSend(kSslClientHello, sizeof(kSslClientHello));
   if (res != sizeof(kSslClientHello)) {
+    RTC_LOG(LS_ERROR) << "Sending fake SSL ClientHello message failed.";
     Close();
     SignalCloseEvent(this, 0);
   }
@@ -193,6 +194,7 @@
     return;
 
   if (memcmp(kSslServerHello, data, sizeof(kSslServerHello)) != 0) {
+    RTC_LOG(LS_ERROR) << "Received non-matching fake SSL ServerHello message.";
     Close();
     SignalCloseEvent(this, 0);  // TODO: error code?
     return;