Revert "Report parsed key id on SFrame unknown-key decrypt failures"

This reverts commit 43f5a1c963381978d29a2f2b85633bb9ad7303f5.

Reason for revert: Breaks downstream build


Original change's description:
> Report parsed key id on SFrame unknown-key decrypt failures
>
> `ToSframeDecryptFailure` previously mapped `invalid_parameter_error` to
> a `kKeyId` failure with an empty key id, because the Cisco Sframe
> library did not surface the key id parsed from the SFrame header.
>
> The library now returns a dedicated
> `SFrameErrorType::unknown_key_id_error` carrying the parsed key id, so
> the mapping is switched over to it and the key id is propagated into
> `SframeDecryptFailure::KeyId`. Applications listening for
> `SframeDecryptErrorCallback` can now tell *which* key is missing,
> matching
> [SFrameTransformErrorEvent.keyID](https://w3c.github.io/webrtc-encoded-transform/#dom-sframetransformerrorevent-keyid).
>
> `invalid_parameter_error` now falls through to the `kSyntax` default,
> which is the correct classification for a malformed header.
>
> Additional changes:
> - Re-enabled `SframeEncryptorDecryptorTest.DISABLED_DecryptReportsKeyIdErrorForUnknownKey`
>   and tightened it to assert the reported key id equals the encryption key id.
>
> Bug: webrtc:479862368
> Change-Id: I5af6c6b42f1fe46acbdeba6168d4a20f1f8a0869
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/506020
> Commit-Queue: Kacper Wasniowski <kwasniow@cisco.com>
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#48732}

Bug: webrtc:479862368
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I8d7a55bf4b80a8027853178664e88732ca3f2915
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/506120
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Auto-Submit: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#48738}
2 files changed
tree: 6153fc4f0550780be216d4cce6b23cb279ca43ea
  1. .agents/
  2. agents/
  3. api/
  4. audio/
  5. build_overrides/
  6. call/
  7. common_audio/
  8. common_video/
  9. data/
  10. docs/
  11. examples/
  12. experiments/
  13. g3doc/
  14. infra/
  15. logging/
  16. media/
  17. modules/
  18. net/
  19. p2p/
  20. pc/
  21. resources/
  22. rtc_base/
  23. rtc_tools/
  24. rust/
  25. sdk/
  26. stats/
  27. system_wrappers/
  28. test/
  29. tools_webrtc/
  30. video/
  31. .clang-format
  32. .clang-tidy
  33. .git-blame-ignore-revs
  34. .gitignore
  35. .gn
  36. .mailmap
  37. .rustfmt.toml
  38. .style.mdformat
  39. .style.yapf
  40. .yapfignore
  41. AUTHORS
  42. BUILD.gn
  43. CODE_OF_CONDUCT.md
  44. codereview.settings
  45. DEPS
  46. DIR_METADATA
  47. ENG_REVIEW_OWNERS
  48. GEMINI.md
  49. LICENSE
  50. license_template.txt
  51. native-api.md
  52. OWNERS
  53. OWNERS_INFRA
  54. PATENTS
  55. PRESUBMIT.py
  56. presubmit_test.py
  57. presubmit_test_mocks.py
  58. pylintrc
  59. pylintrc_old_style
  60. README.chromium
  61. README.md
  62. unsafe_buffers_paths.txt
  63. vpython.toml
  64. vpython.toml.uv.lock
  65. WATCHLISTS
  66. webrtc.gni
  67. webrtc_lib_link_test.cc
  68. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info