commit 3beacb7a871db95671f10c5160e8ded45d722f68
author Danil Chapovalov <danilchap@webrtc.org> Fri Mar 31 11:15:05 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Mar 31 14:43:44 2023
tree c1fcb1e52fafa04942e484db20584603ce7b6652
parent 2bac7ef2447448b81e148d3fe35badb33a4129fa

Create default video factories directly instead of through legacy public helpers

Bug: webrtc:13573
Change-Id: If8ab26dc45cce2dac17572772bb21806a54ed3e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299660
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39729}

media/BUILD.gn

diff --git a/media/BUILD.gn b/media/BUILD.gn
index 8f85067..0179462 100644
--- a/media/BUILD.gn
+++ b/media/BUILD.gn
@@ -553,12 +553,11 @@
   ]
   deps = [
     ":rtc_audio_video",
+    ":rtc_internal_video_codecs",
     "../api/audio_codecs:builtin_audio_decoder_factory",
     "../api/audio_codecs:builtin_audio_encoder_factory",
     "../api/task_queue:default_task_queue_factory",
     "../api/video:builtin_video_bitrate_allocator_factory",
-    "../api/video_codecs:builtin_video_decoder_factory",
-    "../api/video_codecs:builtin_video_encoder_factory",
     "../modules/audio_processing:api",
     "../rtc_base:checks",
     "../rtc_base/system:rtc_export",

media/engine/webrtc_media_engine_defaults.cc

diff --git a/media/engine/webrtc_media_engine_defaults.cc b/media/engine/webrtc_media_engine_defaults.cc
index 1660873..9df6b08 100644
--- a/media/engine/webrtc_media_engine_defaults.cc
+++ b/media/engine/webrtc_media_engine_defaults.cc
@@ -9,12 +9,14 @@
  */
 #include "media/engine/webrtc_media_engine_defaults.h"
 
+#include <memory>
+
 #include "api/audio_codecs/builtin_audio_decoder_factory.h"
 #include "api/audio_codecs/builtin_audio_encoder_factory.h"
 #include "api/task_queue/default_task_queue_factory.h"
 #include "api/video/builtin_video_bitrate_allocator_factory.h"
-#include "api/video_codecs/builtin_video_decoder_factory.h"
-#include "api/video_codecs/builtin_video_encoder_factory.h"
+#include "media/engine/internal_decoder_factory.h"
+#include "media/engine/internal_encoder_factory.h"
 #include "modules/audio_processing/include/audio_processing.h"
 #include "rtc_base/checks.h"
 
@@ -35,9 +37,9 @@
     deps->audio_processing = AudioProcessingBuilder().Create();
 
   if (deps->video_encoder_factory == nullptr)
-    deps->video_encoder_factory = CreateBuiltinVideoEncoderFactory();
+    deps->video_encoder_factory = std::make_unique<InternalEncoderFactory>();
   if (deps->video_decoder_factory == nullptr)
-    deps->video_decoder_factory = CreateBuiltinVideoDecoderFactory();
+    deps->video_decoder_factory = std::make_unique<InternalDecoderFactory>();
 }
 
 }  // namespace webrtc