commit 3c21189ae923932472223a04b6e1d4621814a60e
author Per K <perkj@webrtc.org> Fri Aug 08 07:50:27 2025
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 08 16:20:13 2025
tree c9a93731790b777799001adf6272ad77337afa37
parent bddd6da943396cc9de09a2ef85d174f192d84082

Dont use arrival time as current time when deciding to send feedback

Due to that the arrival time may be slightly ahead of current time if socket
compansate for different time base.

Bug: webrtc:42225697
Change-Id: I9e08047fae53e70e27c9c98b478bfc5d02b30afe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403580
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45309}

modules/remote_bitrate_estimator/congestion_control_feedback_generator.cc

diff --git a/modules/remote_bitrate_estimator/congestion_control_feedback_generator.cc b/modules/remote_bitrate_estimator/congestion_control_feedback_generator.cc
index fbfbf6f..80b0f93 100644
--- a/modules/remote_bitrate_estimator/congestion_control_feedback_generator.cc
+++ b/modules/remote_bitrate_estimator/congestion_control_feedback_generator.cc
@@ -54,12 +54,13 @@
   RTC_DCHECK_RUN_ON(&sequence_checker_);
 
   marker_bit_seen_ |= packet.Marker();
+  Timestamp now = env_.clock().CurrentTime();
   if (!first_arrival_time_since_feedback_) {
-    first_arrival_time_since_feedback_ = packet.arrival_time();
+    first_arrival_time_since_feedback_ = now;
   }
   feedback_trackers_[packet.Ssrc()].ReceivedPacket(packet);
-  if (NextFeedbackTime() < packet.arrival_time()) {
-    SendFeedback(env_.clock().CurrentTime());
+  if (NextFeedbackTime() < now) {
+    SendFeedback(now);
   }
 }