Comment unused variables in implemented functions 5\n
Bug: webrtc:370878648
Change-Id: I8ac032b5621fd0a75bce11541133579d22f63af3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364684
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43280}
diff --git a/logging/rtc_event_log/events/rtc_event_rtp_packet_incoming.h b/logging/rtc_event_log/events/rtc_event_rtp_packet_incoming.h
index 9b9e725..454056a 100644
--- a/logging/rtc_event_log/events/rtc_event_rtp_packet_incoming.h
+++ b/logging/rtc_event_log/events/rtc_event_rtp_packet_incoming.h
@@ -69,15 +69,15 @@
size_t header_length() const { return packet_.headers_size(); }
size_t padding_length() const { return packet_.padding_size(); }
- static std::string Encode(rtc::ArrayView<const RtcEvent*> batch) {
+ static std::string Encode(rtc::ArrayView<const RtcEvent*> /* batch */) {
// TODO(terelius): Implement
return "";
}
static RtcEventLogParseStatus Parse(
- absl::string_view encoded_bytes,
- bool batched,
- std::map<uint32_t, std::vector<LoggedRtpPacketIncoming>>& output) {
+ absl::string_view /* encoded_bytes */,
+ bool /* batched */,
+ std::map<uint32_t, std::vector<LoggedRtpPacketIncoming>>& /* output */) {
// TODO(terelius): Implement
return RtcEventLogParseStatus::Error("Not Implemented", __FILE__, __LINE__);
}
diff --git a/logging/rtc_event_log/events/rtc_event_rtp_packet_outgoing.h b/logging/rtc_event_log/events/rtc_event_rtp_packet_outgoing.h
index d4004a4..caf485d 100644
--- a/logging/rtc_event_log/events/rtc_event_rtp_packet_outgoing.h
+++ b/logging/rtc_event_log/events/rtc_event_rtp_packet_outgoing.h
@@ -71,15 +71,15 @@
size_t padding_length() const { return packet_.padding_size(); }
int probe_cluster_id() const { return probe_cluster_id_; }
- static std::string Encode(rtc::ArrayView<const RtcEvent*> batch) {
+ static std::string Encode(rtc::ArrayView<const RtcEvent*> /* batch */) {
// TODO(terelius): Implement
return "";
}
static RtcEventLogParseStatus Parse(
- absl::string_view encoded_bytes,
- bool batched,
- std::map<uint32_t, std::vector<LoggedRtpPacketOutgoing>>& output) {
+ absl::string_view /* encoded_bytes */,
+ bool /* batched */,
+ std::map<uint32_t, std::vector<LoggedRtpPacketOutgoing>>& /* output */) {
// TODO(terelius): Implement
return RtcEventLogParseStatus::Error("Not Implemented", __FILE__, __LINE__);
}
diff --git a/modules/audio_device/audio_device_generic.cc b/modules/audio_device/audio_device_generic.cc
index 7b8cfd1..e123937 100644
--- a/modules/audio_device/audio_device_generic.cc
+++ b/modules/audio_device/audio_device_generic.cc
@@ -19,7 +19,7 @@
return false;
}
-int32_t AudioDeviceGeneric::EnableBuiltInAEC(bool enable) {
+int32_t AudioDeviceGeneric::EnableBuiltInAEC(bool /* enable */) {
RTC_LOG_F(LS_ERROR) << "Not supported on this platform";
return -1;
}
@@ -29,7 +29,7 @@
return false;
}
-int32_t AudioDeviceGeneric::EnableBuiltInAGC(bool enable) {
+int32_t AudioDeviceGeneric::EnableBuiltInAGC(bool /* enable */) {
RTC_LOG_F(LS_ERROR) << "Not supported on this platform";
return -1;
}
@@ -39,7 +39,7 @@
return false;
}
-int32_t AudioDeviceGeneric::EnableBuiltInNS(bool enable) {
+int32_t AudioDeviceGeneric::EnableBuiltInNS(bool /* enable */) {
RTC_LOG_F(LS_ERROR) << "Not supported on this platform";
return -1;
}
diff --git a/modules/audio_device/dummy/audio_device_dummy.cc b/modules/audio_device/dummy/audio_device_dummy.cc
index b8fd837..551575c 100644
--- a/modules/audio_device/dummy/audio_device_dummy.cc
+++ b/modules/audio_device/dummy/audio_device_dummy.cc
@@ -13,7 +13,7 @@
namespace webrtc {
int32_t AudioDeviceDummy::ActiveAudioLayer(
- AudioDeviceModule::AudioLayer& audioLayer) const {
+ AudioDeviceModule::AudioLayer& /* audioLayer */) const {
return -1;
}
@@ -37,37 +37,39 @@
return -1;
}
-int32_t AudioDeviceDummy::PlayoutDeviceName(uint16_t index,
- char name[kAdmMaxDeviceNameSize],
- char guid[kAdmMaxGuidSize]) {
+int32_t AudioDeviceDummy::PlayoutDeviceName(
+ uint16_t /* index */,
+ char /* name */[kAdmMaxDeviceNameSize],
+ char /* guid */[kAdmMaxGuidSize]) {
return -1;
}
-int32_t AudioDeviceDummy::RecordingDeviceName(uint16_t index,
- char name[kAdmMaxDeviceNameSize],
- char guid[kAdmMaxGuidSize]) {
+int32_t AudioDeviceDummy::RecordingDeviceName(
+ uint16_t /* index */,
+ char /* name */[kAdmMaxDeviceNameSize],
+ char /* guid */[kAdmMaxGuidSize]) {
return -1;
}
-int32_t AudioDeviceDummy::SetPlayoutDevice(uint16_t index) {
+int32_t AudioDeviceDummy::SetPlayoutDevice(uint16_t /* index */) {
return -1;
}
int32_t AudioDeviceDummy::SetPlayoutDevice(
- AudioDeviceModule::WindowsDeviceType device) {
+ AudioDeviceModule::WindowsDeviceType /* device */) {
return -1;
}
-int32_t AudioDeviceDummy::SetRecordingDevice(uint16_t index) {
+int32_t AudioDeviceDummy::SetRecordingDevice(uint16_t /* index */) {
return -1;
}
int32_t AudioDeviceDummy::SetRecordingDevice(
- AudioDeviceModule::WindowsDeviceType device) {
+ AudioDeviceModule::WindowsDeviceType /* device */) {
return -1;
}
-int32_t AudioDeviceDummy::PlayoutIsAvailable(bool& available) {
+int32_t AudioDeviceDummy::PlayoutIsAvailable(bool& /* available */) {
return -1;
}
@@ -79,7 +81,7 @@
return false;
}
-int32_t AudioDeviceDummy::RecordingIsAvailable(bool& available) {
+int32_t AudioDeviceDummy::RecordingIsAvailable(bool& /* available */) {
return -1;
}
@@ -131,27 +133,27 @@
return false;
}
-int32_t AudioDeviceDummy::SpeakerVolumeIsAvailable(bool& available) {
+int32_t AudioDeviceDummy::SpeakerVolumeIsAvailable(bool& /* available */) {
return -1;
}
-int32_t AudioDeviceDummy::SetSpeakerVolume(uint32_t volume) {
+int32_t AudioDeviceDummy::SetSpeakerVolume(uint32_t /* volume */) {
return -1;
}
-int32_t AudioDeviceDummy::SpeakerVolume(uint32_t& volume) const {
+int32_t AudioDeviceDummy::SpeakerVolume(uint32_t& /* volume */) const {
return -1;
}
-int32_t AudioDeviceDummy::MaxSpeakerVolume(uint32_t& maxVolume) const {
+int32_t AudioDeviceDummy::MaxSpeakerVolume(uint32_t& /* maxVolume */) const {
return -1;
}
-int32_t AudioDeviceDummy::MinSpeakerVolume(uint32_t& minVolume) const {
+int32_t AudioDeviceDummy::MinSpeakerVolume(uint32_t& /* minVolume */) const {
return -1;
}
-int32_t AudioDeviceDummy::MicrophoneVolumeIsAvailable(bool& available) {
+int32_t AudioDeviceDummy::MicrophoneVolumeIsAvailable(bool& /* available */) {
return -1;
}
diff --git a/modules/audio_device/dummy/file_audio_device.cc b/modules/audio_device/dummy/file_audio_device.cc
index 8c10ae4..6009138 100644
--- a/modules/audio_device/dummy/file_audio_device.cc
+++ b/modules/audio_device/dummy/file_audio_device.cc
@@ -50,7 +50,7 @@
FileAudioDevice::~FileAudioDevice() {}
int32_t FileAudioDevice::ActiveAudioLayer(
- AudioDeviceModule::AudioLayer& audioLayer) const {
+ AudioDeviceModule::AudioLayer& /* audioLayer */) const {
return -1;
}
@@ -113,7 +113,7 @@
}
int32_t FileAudioDevice::SetPlayoutDevice(
- AudioDeviceModule::WindowsDeviceType device) {
+ AudioDeviceModule::WindowsDeviceType /* device */) {
return -1;
}
@@ -126,7 +126,7 @@
}
int32_t FileAudioDevice::SetRecordingDevice(
- AudioDeviceModule::WindowsDeviceType device) {
+ AudioDeviceModule::WindowsDeviceType /* device */) {
return -1;
}
@@ -332,67 +332,67 @@
return true;
}
-int32_t FileAudioDevice::SpeakerVolumeIsAvailable(bool& available) {
+int32_t FileAudioDevice::SpeakerVolumeIsAvailable(bool& /* available */) {
return -1;
}
-int32_t FileAudioDevice::SetSpeakerVolume(uint32_t volume) {
+int32_t FileAudioDevice::SetSpeakerVolume(uint32_t /* volume */) {
return -1;
}
-int32_t FileAudioDevice::SpeakerVolume(uint32_t& volume) const {
+int32_t FileAudioDevice::SpeakerVolume(uint32_t& /* volume */) const {
return -1;
}
-int32_t FileAudioDevice::MaxSpeakerVolume(uint32_t& maxVolume) const {
+int32_t FileAudioDevice::MaxSpeakerVolume(uint32_t& /* maxVolume */) const {
return -1;
}
-int32_t FileAudioDevice::MinSpeakerVolume(uint32_t& minVolume) const {
+int32_t FileAudioDevice::MinSpeakerVolume(uint32_t& /* minVolume */) const {
return -1;
}
-int32_t FileAudioDevice::MicrophoneVolumeIsAvailable(bool& available) {
+int32_t FileAudioDevice::MicrophoneVolumeIsAvailable(bool& /* available */) {
return -1;
}
-int32_t FileAudioDevice::SetMicrophoneVolume(uint32_t volume) {
+int32_t FileAudioDevice::SetMicrophoneVolume(uint32_t /* volume */) {
return -1;
}
-int32_t FileAudioDevice::MicrophoneVolume(uint32_t& volume) const {
+int32_t FileAudioDevice::MicrophoneVolume(uint32_t& /* volume */) const {
return -1;
}
-int32_t FileAudioDevice::MaxMicrophoneVolume(uint32_t& maxVolume) const {
+int32_t FileAudioDevice::MaxMicrophoneVolume(uint32_t& /* maxVolume */) const {
return -1;
}
-int32_t FileAudioDevice::MinMicrophoneVolume(uint32_t& minVolume) const {
+int32_t FileAudioDevice::MinMicrophoneVolume(uint32_t& /* minVolume */) const {
return -1;
}
-int32_t FileAudioDevice::SpeakerMuteIsAvailable(bool& available) {
+int32_t FileAudioDevice::SpeakerMuteIsAvailable(bool& /* available */) {
return -1;
}
-int32_t FileAudioDevice::SetSpeakerMute(bool enable) {
+int32_t FileAudioDevice::SetSpeakerMute(bool /* enable */) {
return -1;
}
-int32_t FileAudioDevice::SpeakerMute(bool& enabled) const {
+int32_t FileAudioDevice::SpeakerMute(bool& /* enabled */) const {
return -1;
}
-int32_t FileAudioDevice::MicrophoneMuteIsAvailable(bool& available) {
+int32_t FileAudioDevice::MicrophoneMuteIsAvailable(bool& /* available */) {
return -1;
}
-int32_t FileAudioDevice::SetMicrophoneMute(bool enable) {
+int32_t FileAudioDevice::SetMicrophoneMute(bool /* enable */) {
return -1;
}
-int32_t FileAudioDevice::MicrophoneMute(bool& enabled) const {
+int32_t FileAudioDevice::MicrophoneMute(bool& /* enabled */) const {
return -1;
}
diff --git a/modules/audio_device/dummy/file_audio_device_factory.cc b/modules/audio_device/dummy/file_audio_device_factory.cc
index 8c41111..7a6ee1e 100644
--- a/modules/audio_device/dummy/file_audio_device_factory.cc
+++ b/modules/audio_device/dummy/file_audio_device_factory.cc
@@ -40,8 +40,8 @@
}
void FileAudioDeviceFactory::SetFilenamesToUse(
- absl::string_view inputAudioFilename,
- absl::string_view outputAudioFilename) {
+ [[maybe_unused]] absl::string_view inputAudioFilename,
+ [[maybe_unused]] absl::string_view outputAudioFilename) {
#ifdef WEBRTC_DUMMY_FILE_DEVICES
RTC_DCHECK_LT(inputAudioFilename.size(), MAX_FILENAME_LEN);
RTC_DCHECK_LT(outputAudioFilename.size(), MAX_FILENAME_LEN);
