commit 3fede875feb74d54f75c899d0b1df0f98add4a6c
author Philipp Hancke <phancke@meta.com> Thu Jun 13 15:05:15 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 25 16:10:15 2024
tree 27d738cead767f3558db8dd68b0d99a3c74451ea
parent 27abd690cc64ed09ad79f5d5a37d92806f941876

Remove rtc_base/helpers.h and crypto_random include in port allocator

after fixing Chromium (and possibly other downstream projects)

BUG=webrtc:339300437

Change-Id: I1637b379ce778e78b4fb73cb44b291c2f66c3606
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/353766
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42533}

rtc_base/BUILD.gn

diff --git a/rtc_base/BUILD.gn b/rtc_base/BUILD.gn
index 5405241..f095b22 100644
--- a/rtc_base/BUILD.gn
+++ b/rtc_base/BUILD.gn
@@ -1529,7 +1529,6 @@
 rtc_library("ssl") {
   visibility = [ "*" ]
   sources = [
-    "helpers.h",
     "openssl_key_pair.cc",
     "openssl_key_pair.h",
     "openssl_utility.cc",
@@ -1545,39 +1544,25 @@
   ]
 
   deps = [
-    ":async_socket",
     ":buffer",
     ":checks",
     ":copy_on_write_buffer",
-    ":crypto_random",
     ":digest",
     ":logging",
     ":macromagic",
     ":safe_conversions",
-    ":socket",
-    ":socket_address",
     ":ssl_header",
-    ":stream",
     ":stringutils",
-    ":threading",
     ":timeutils",
     "../api:array_view",
     "../api:refcountedbase",
     "../api:scoped_refptr",
-    "../api/task_queue:pending_task_safety_flag",
-    "../api/units:time_delta",
-    "../system_wrappers:field_trial",
-    "synchronization:mutex",
     "system:rtc_export",
-    "task_utils:repeating_task",
     "third_party/base64",
-    "third_party/sigslot",
     "//third_party/abseil-cpp/absl/algorithm:container",
     "//third_party/abseil-cpp/absl/base:core_headers",
-    "//third_party/abseil-cpp/absl/functional:any_invocable",
     "//third_party/abseil-cpp/absl/memory",
     "//third_party/abseil-cpp/absl/strings:string_view",
-    "//third_party/abseil-cpp/absl/types:optional",
   ]
 
   # If we are building the SSL library ourselves, we know it's BoringSSL.
@@ -1589,7 +1574,10 @@
       "boringssl_identity.h",
     ]
 
-    deps += [ "//third_party/boringssl" ]
+    deps += [
+      ":crypto_random",
+      "//third_party/boringssl",
+    ]
   } else {
     sources += [
       "openssl_certificate.cc",