commit 3ffe94314a3f18402b159e6c7146088c48137de5
author Björn Terelius <terelius@webrtc.org> Mon Nov 18 10:35:47 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Nov 18 11:51:15 2024
tree b4e5d011261b292f950eace9388d42b05b85b7e8
parent 69cc6956999204539e68aa33d190391fe6fa61f8

Fix lint warnings in TaskQueueStdlib

Bug: None
Change-Id: I4fd89dac39c0585793601d7adb5181a6ac15a64f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/368460
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43415}

rtc_base/task_queue_stdlib.cc

diff --git a/rtc_base/task_queue_stdlib.cc b/rtc_base/task_queue_stdlib.cc
index 8b9e554..e2b89b8 100644
--- a/rtc_base/task_queue_stdlib.cc
+++ b/rtc_base/task_queue_stdlib.cc
@@ -16,6 +16,7 @@
 #include <map>
 #include <memory>
 #include <queue>
+#include <tuple>
 #include <utility>
 
 #include "absl/functional/any_invocable.h"
@@ -200,12 +201,12 @@
     return result;
   }
 
-  if (delayed_queue_.size() > 0) {
+  if (!delayed_queue_.empty()) {
     auto delayed_entry = delayed_queue_.begin();
     const auto& delay_info = delayed_entry->first;
     auto& delay_run = delayed_entry->second;
     if (tick_us >= delay_info.next_fire_at_us) {
-      if (pending_queue_.size() > 0) {
+      if (!pending_queue_.empty()) {
         auto& entry = pending_queue_.front();
         auto& entry_order = entry.first;
         auto& entry_run = entry.second;
@@ -225,7 +226,7 @@
         DivideRoundUp(delay_info.next_fire_at_us - tick_us, 1'000));
   }
 
-  if (pending_queue_.size() > 0) {
+  if (!pending_queue_.empty()) {
     auto& entry = pending_queue_.front();
     result.run_task = std::move(entry.second);
     pending_queue_.pop();

rtc_base/task_queue_stdlib_unittest.cc

diff --git a/rtc_base/task_queue_stdlib_unittest.cc b/rtc_base/task_queue_stdlib_unittest.cc
index 97f0a2c..ab0d7fd 100644
--- a/rtc_base/task_queue_stdlib_unittest.cc
+++ b/rtc_base/task_queue_stdlib_unittest.cc
@@ -10,6 +10,9 @@
 
 #include "rtc_base/task_queue_stdlib.h"
 
+#include <memory>
+#include <string>
+
 #include "api/task_queue/task_queue_factory.h"
 #include "api/task_queue/task_queue_test.h"
 #include "api/units/time_delta.h"