commit | 40b5bd72d0d7d62d81bd8bcc3f8cae0d15877f5b | [log] [tgz] |
---|---|---|
author | Alessio Bazzica <alessiob@webrtc.org> | Mon Jan 16 19:19:48 2023 |
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jan 16 20:30:12 2023 |
tree | ce213e2319f051dc9c476417a84f635fa9a1911a | |
parent | f7a46e55cba6d39cc3f9e48a0ab04463e0ba06b9 [diff] |
APM: fix TS initialization bugs with `WebRTC-Audio-GainController2` When the `WebRTC-Audio-GainController2` field trial is used, the initial APM configuration is adjusted depending on its original values and the field trial parameters. This CL fixes two cases when the code crashes: 1. when, in the initial APM config, AGC1 is enabled, AGC2 is disabled and TS is enabled 2. when the initial APM sample rate is different from the capture one and the VAD APM sub-module is not re-initialized This CL also improves the unit tests coverage and it has been tested offline to check that the VAD sub-module is created only when expected and that AGC2 uses its internal VAD when expected. The tests ran on a few Wav files with different sample rates and one AEC dump and on 16 different APM and field trial configurations. Bug: chromium:1407341, b/265112132 Change-Id: I7cc267ea81cb02be92c1f37f273b7ae93b6e4634 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290988 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Olga Sharonova <olka@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39118}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.