Google Git
Sign in
webrtc / src / ba8780fb851626daa89cf7c025460dd11fc78ed4
commitba8780fb851626daa89cf7c025460dd11fc78ed4[log] [tgz]
authorJoe Downing <joedow@google.com>Fri Apr 09 19:34:35 2021
committerCommit Bot <commit-bot@chromium.org>Wed Apr 14 20:08:52 2021
tree3569bc80b49e0f6882b6563bc604c8f82f32f1a0
parent82c48211ec3d25d5f696307e2ef691c267cb62ce [diff]
Fixing a buffer copy issue in DesktopFrame

This CL fixes a buffer copying issue introduced in this CL:
https://webrtc-review.googlesource.com/c/src/+/196485

In the BasicDesktopFrame::CopyOf function, the src and dst params
were swapped.  For me this manifested as a missing cursor when using
Chrome Remote Desktop.  I don't know of any other bugs this caused
but I have to assume it affects all callers of the function given
that the copy will never occur.

(cherry picked from commit f2f9bb66ca33176cc931c679f8c379ede5b53469)

Bug: chromium:1197210
Change-Id: I076bffbad1d658b1c6f4b0dffea17d339c867bef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214840
Commit-Queue: Joe Downing <joedow@google.com>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#33672}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215240
Cr-Commit-Position: refs/branch-heads/4472@{#3}
Cr-Branched-From: 3e0c60ba4ef28a9f26fe991e5eec3150402c7dd3-refs/heads/master@{#33644}
1 file changed
tree: 3569bc80b49e0f6882b6563bc604c8f82f32f1a0
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. docs/
  9. examples/
  10. g3doc/
  11. logging/
  12. media/
  13. modules/
  14. net/
  15. p2p/
  16. pc/
  17. resources/
  18. rtc_base/
  19. rtc_tools/
  20. sdk/
  21. stats/
  22. style-guide/
  23. system_wrappers/
  24. test/
  25. tools_webrtc/
  26. video/
  27. .clang-format
  28. .git-blame-ignore-revs
  29. .gitignore
  30. .gn
  31. .vpython
  32. abseil-in-webrtc.md
  33. AUTHORS
  34. BUILD.gn
  35. CODE_OF_CONDUCT.md
  36. codereview.settings
  37. DEPS
  38. DIR_METADATA
  39. ENG_REVIEW_OWNERS
  40. g3doc.lua
  41. LICENSE
  42. license_template.txt
  43. native-api.md
  44. OWNERS
  45. PATENTS
  46. PRESUBMIT.py
  47. presubmit_test.py
  48. presubmit_test_mocks.py
  49. pylintrc
  50. README.chromium
  51. README.md
  52. style-guide.md
  53. WATCHLISTS
  54. webrtc.gni
  55. webrtc_lib_link_test.cc
  56. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info