Privatize remaining public signals.
Bug: webrtc:42222066
Change-Id: I341b2ad854873e600cefc2ea7c04ab38c48ca906
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/427700
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Auto-Submit: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#46268}
diff --git a/rtc_base/proxy_server.h b/rtc_base/proxy_server.h
index 2f6a69d..a89ee80 100644
--- a/rtc_base/proxy_server.h
+++ b/rtc_base/proxy_server.h
@@ -41,7 +41,6 @@
ProxyBinding(const ProxyBinding&) = delete;
ProxyBinding& operator=(const ProxyBinding&) = delete;
- sigslot::signal1<ProxyBinding*> SignalDestroyed;
void SubscribeDestroyed(
absl::AnyInvocable<void(ProxyBinding* proxy)> callback) {
destroyed_trampoline_.Subscribe(std::move(callback));
@@ -49,6 +48,7 @@
void NotifyDestroyed(ProxyBinding* proxy) { SignalDestroyed(proxy); }
private:
+ sigslot::signal1<ProxyBinding*> SignalDestroyed;
void OnConnectRequest(AsyncProxyServerSocket* socket,
const SocketAddress& addr);
void OnInternalRead(Socket* socket);
diff --git a/rtc_base/server_socket_adapters.h b/rtc_base/server_socket_adapters.h
index d65bf81..da7ef9d 100644
--- a/rtc_base/server_socket_adapters.h
+++ b/rtc_base/server_socket_adapters.h
@@ -28,8 +28,6 @@
public:
AsyncProxyServerSocket(Socket* socket, size_t buffer_size);
~AsyncProxyServerSocket() override;
- sigslot::signal2<AsyncProxyServerSocket*, const SocketAddress&>
- SignalConnectRequest;
void SubscribeConnectRequest(
absl::AnyInvocable<void(AsyncProxyServerSocket*, const SocketAddress&)>
@@ -44,6 +42,8 @@
virtual void SendConnectResult(int err, const SocketAddress& addr) = 0;
private:
+ sigslot::signal2<AsyncProxyServerSocket*, const SocketAddress&>
+ SignalConnectRequest;
SignalTrampoline<AsyncProxyServerSocket,
&AsyncProxyServerSocket::SignalConnectRequest>
connect_request_trampoline_;
diff --git a/rtc_base/virtual_socket_server.h b/rtc_base/virtual_socket_server.h
index c144264..e8725fa 100644
--- a/rtc_base/virtual_socket_server.h
+++ b/rtc_base/virtual_socket_server.h
@@ -388,7 +388,6 @@
// Sending was previously blocked, but now isn't.
// Deprecated interface
- sigslot::signal0<> SignalReadyToSend;
// New interface
void NotifyReadyToSend() { SignalReadyToSend(); }
void SubscribeReadyToSend(absl::AnyInvocable<void()> callback) {
@@ -499,6 +498,7 @@
size_t max_udp_payload_ RTC_GUARDED_BY(mutex_) = 65507;
bool sending_blocked_ RTC_GUARDED_BY(mutex_) = false;
+ sigslot::signal0<> SignalReadyToSend;
SignalTrampoline<VirtualSocketServer, &VirtualSocketServer::SignalReadyToSend>
ready_to_send_trampoline_;
};