| commit | 4a482a2160e2e1aa3ec2858d8b6351d147a380ec | [log] [tgz] |
|---|---|---|
| author | Alessio Bazzica <alessiob@webrtc.org> | Tue Oct 29 11:12:31 2024 |
| committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 29 13:58:21 2024 |
| tree | be6e09d784295b52d1aee0922db373c3abf5eb4c | |
| parent | e8c8218f1b3a94bb43ad3f5f5e202dcb2657f6f3 [diff] |
Add TODO in the Opus encoder where the application param is set Bug: webrtc:376071290 Change-Id: Idd9017435bab9f8b53771c0dd642fd4ce3db048e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366981 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43323}
diff --git a/modules/audio_coding/codecs/opus/audio_encoder_opus.cc b/modules/audio_coding/codecs/opus/audio_encoder_opus.cc index 288ee84..3fb926a 100644 --- a/modules/audio_coding/codecs/opus/audio_encoder_opus.cc +++ b/modules/audio_coding/codecs/opus/audio_encoder_opus.cc
@@ -245,6 +245,7 @@ config.bitrate_bps = CalculateBitrate(config.max_playback_rate_hz, config.num_channels, GetFormatParameter(format, "maxaveragebitrate")); + // TODO: https://issues.webrtc.org/376071290 - Use `contentHint` if available. config.application = config.num_channels == 1 ? AudioEncoderOpusConfig::ApplicationMode::kVoip : AudioEncoderOpusConfig::ApplicationMode::kAudio;