commit | 4c4cb5b98456cb16d9174485bd59e58a861fd0f5 | [log] [tgz] |
---|---|---|
author | skvlad <skvlad@webrtc.org> | Wed Jun 29 22:30:41 2016 |
committer | Commit bot <commit-bot@chromium.org> | Wed Jun 29 22:30:48 2016 |
tree | bfff8a397d0d9efb4ac7cf48a50e24d8bd8a059b | |
parent | ca4cac7e7494e7b5d60bda4b21b6a00592f8e1df [diff] |
Separate the JNI function that controls logging levels into two. The parameters for Logging.enableTracing() were creating the impression that they control level and severity of one tracing system and they are meant to be used together. In fact the "levels" parameter controlled one tracing system (WEBRTC_TRACE), and the "severity" parameter was responsible for a completely different one: setting the severity level above which log messages from LOG() will be directed to the platform-specific debug output (logcat on Android). The method signature suggested that the "path" parameter applied to both systems - while it was only meaningful for the WEBRTC_TRACE; LOG messages were directed to ADB logcat no matter what the Path value was. It is possible to redirect LOG messages to a file, but that is done using a completely different set of APIs - PeerConnectionFactory.startInternalTracingCapture(). I've separated these two methods to make it more clear which of the parameters controls which system. NOTRY=true Review-Url: https://codereview.webrtc.org/2110853003 Cr-Commit-Position: refs/heads/master@{#13334}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.