commit 4c7271aafef89f62381f502f094e2a30421b2498
author Philipp Hancke <phancke@microsoft.com> Wed Feb 22 09:46:57 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Feb 23 10:23:48 2023
tree 83a483a7e64d0eca1a2d43645dbbc6a37cf2b9f8
parent 5e482c1613cabe96bf54904916d9356129a741e3

Remove ISAC media constant and payload type mapping

following the removal of ISAC from the code base.

BUG=webrtc:14450

Change-Id: I6faab5391bf0ef563c5dcce0bd5d8a653a87d9c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294523
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#39378}

media/base/media_constants.cc

diff --git a/media/base/media_constants.cc b/media/base/media_constants.cc
index 2f29a20..f91ac33 100644
--- a/media/base/media_constants.cc
+++ b/media/base/media_constants.cc
@@ -44,7 +44,6 @@
 const char kCodecParamNotInNameValueFormat[] = "";
 
 const char kOpusCodecName[] = "opus";
-const char kIsacCodecName[] = "ISAC";
 const char kL16CodecName[] = "L16";
 const char kG722CodecName[] = "G722";
 const char kIlbcCodecName[] = "ILBC";

media/base/media_constants.h

diff --git a/media/base/media_constants.h b/media/base/media_constants.h
index f843d50..ca3213e 100644
--- a/media/base/media_constants.h
+++ b/media/base/media_constants.h
@@ -45,7 +45,6 @@
 extern const char kCodecParamNotInNameValueFormat[];
 
 extern const char kOpusCodecName[];
-extern const char kIsacCodecName[];
 extern const char kL16CodecName[];
 extern const char kG722CodecName[];
 extern const char kIlbcCodecName[];

media/engine/payload_type_mapper.cc

diff --git a/media/engine/payload_type_mapper.cc b/media/engine/payload_type_mapper.cc
index c63d1d7..66c48a7 100644
--- a/media/engine/payload_type_mapper.cc
+++ b/media/engine/payload_type_mapper.cc
@@ -62,8 +62,6 @@
            // Payload type assignments currently used by WebRTC.
            // Includes data to reduce collisions (and thus reassignments)
            {{kIlbcCodecName, 8000, 1}, 102},
-           {{kIsacCodecName, 16000, 1}, 103},
-           {{kIsacCodecName, 32000, 1}, 104},
            {{kCnCodecName, 16000, 1}, 105},
            {{kCnCodecName, 32000, 1}, 106},
            {{kOpusCodecName,

media/engine/payload_type_mapper_unittest.cc

diff --git a/media/engine/payload_type_mapper_unittest.cc b/media/engine/payload_type_mapper_unittest.cc
index 90e113c..92253a0 100644
--- a/media/engine/payload_type_mapper_unittest.cc
+++ b/media/engine/payload_type_mapper_unittest.cc
@@ -50,8 +50,6 @@
   // Tests that the payload mapper knows about the audio formats we've
   // been using in WebRTC, with their hard coded values.
   EXPECT_EQ(102, mapper_.FindMappingFor({kIlbcCodecName, 8000, 1}));
-  EXPECT_EQ(103, mapper_.FindMappingFor({kIsacCodecName, 16000, 1}));
-  EXPECT_EQ(104, mapper_.FindMappingFor({kIsacCodecName, 32000, 1}));
   EXPECT_EQ(105, mapper_.FindMappingFor({kCnCodecName, 16000, 1}));
   EXPECT_EQ(106, mapper_.FindMappingFor({kCnCodecName, 32000, 1}));
   EXPECT_EQ(111, mapper_.FindMappingFor(

sdk/objc/api/peerconnection/RTCRtpCodecParameters.mm

diff --git a/sdk/objc/api/peerconnection/RTCRtpCodecParameters.mm b/sdk/objc/api/peerconnection/RTCRtpCodecParameters.mm
index 753667b..6201e57 100644
--- a/sdk/objc/api/peerconnection/RTCRtpCodecParameters.mm
+++ b/sdk/objc/api/peerconnection/RTCRtpCodecParameters.mm
@@ -21,7 +21,6 @@
 const NSString * const kRTCUlpfecCodecName = @(cricket::kUlpfecCodecName);
 const NSString * const kRTCFlexfecCodecName = @(cricket::kFlexfecCodecName);
 const NSString * const kRTCOpusCodecName = @(cricket::kOpusCodecName);
-const NSString * const kRTCIsacCodecName = @(cricket::kIsacCodecName);
 const NSString * const kRTCL16CodecName  = @(cricket::kL16CodecName);
 const NSString * const kRTCG722CodecName = @(cricket::kG722CodecName);
 const NSString * const kRTCIlbcCodecName = @(cricket::kIlbcCodecName);