Google Git
Sign in
webrtc / src / 5065e5b922a7a22f9e749dad7196bddc5e9c42d3
commit5065e5b922a7a22f9e749dad7196bddc5e9c42d3[log] [tgz]
authorErik Språng <sprang@webrtc.org>Wed Dec 29 15:37:16 2021
committerWebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 29 17:02:38 2021
treec63f2d39d56f485a22c294a61386e3cb4ca25d16
parent5e180749a15300e45d8bb243275c5160850765cb [diff]
Don't configure frame dropping externally for screenshare.

Legacy code depended of setting VideoCodecVP8::frameDroppingOn to false
for screensharing since the reference frame management handles frame
dropping in the VP8 wrapper instead.
Now the frame dropping is instead configured based on what the
Vp8FrameBufferController instance in use signals.

This change unblocks relanding
https://webrtc-review.googlesource.com/c/src/+/242366

This CL also turns frame dropping on for H264 screenshare, which
should be desirable as it allows for quicker recovery from rate control
overshoots.

Bug: webrtc:9734
Change-Id: I34a29edcd41bb5fd07f7f9bf68660472a1570533
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242965
Reviewed-by: Markus Handell <handellm@webrtc.org>
Auto-Submit: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35592}
2 files changed
tree: c63f2d39d56f485a22c294a61386e3cb4ca25d16
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. docs/
  9. examples/
  10. g3doc/
  11. logging/
  12. media/
  13. modules/
  14. net/
  15. p2p/
  16. pc/
  17. resources/
  18. rtc_base/
  19. rtc_tools/
  20. sdk/
  21. stats/
  22. system_wrappers/
  23. test/
  24. tools_webrtc/
  25. video/
  26. .clang-format
  27. .git-blame-ignore-revs
  28. .gitignore
  29. .gn
  30. .style.yapf
  31. .vpython
  32. .vpython3
  33. AUTHORS
  34. BUILD.gn
  35. CODE_OF_CONDUCT.md
  36. codereview.settings
  37. DEPS
  38. DIR_METADATA
  39. ENG_REVIEW_OWNERS
  40. g3doc.lua
  41. LICENSE
  42. license_template.txt
  43. native-api.md
  44. OWNERS
  45. PATENTS
  46. PRESUBMIT.py
  47. presubmit_test.py
  48. presubmit_test_mocks.py
  49. pylintrc
  50. README.chromium
  51. README.md
  52. WATCHLISTS
  53. webrtc.gni
  54. webrtc_lib_link_test.cc
  55. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info