| commit | 563d497e009ffbcb146ba5937dcf8e6779ff47a2 | [log] [tgz] |
|---|---|---|
| author | Markus Handell <handellm@webrtc.org> | Wed Jul 08 13:56:14 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Jul 08 15:10:30 2020 |
| tree | 9dcf64800d63a4dc24ad097ec26dbfb18620fbf4 | |
| parent | 4465ee1d506119aa350bb3d176b1fa22923209e0 [diff] |
SimulatedTaskQueue: release lock before destroying tasks. SimulatedTaskQueue::Delete() was unintentionally holding SimulatedTaskQueue::lock_ while destroying the tasks, which led to SimulatedTimeController::lock_ getting taken. The problem is fixed by destroying the tasks outside the lock. After landing https://webrtc-review.googlesource.com/c/src/+/178818, a downstream test detected a potential deadlock between SimulatedTaskQueue and SimulatedTimeController. While the test deadlock detector did not disclose complete details, it's believed that the deadlock detector reacted because it observed another locking order than it had previously throughout the execution of the test. Bug: webrtc:11567 Change-Id: If6eafe89e2421f0c5acc6aede3419bd4fe470599 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178875 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Markus Handell <handellm@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31679}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.