commit 58d861c47f3b112e3cc5e11da53961dde7e56221
author Ali Tofigh <alito@webrtc.org> Thu Mar 24 23:51:20 2022
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Mar 25 08:11:17 2022
tree 68f6adc227e8f6660f9a49ea394004264285e26b
parent 48aeb965fa0ecb1b18f3f8756f319445fd3b7449

Update missing absl::string_view adoption in openssl files under rtc_base/

Bug: webrtc:13579 webrtc:13870
Change-Id: Ia549285f1a60f41397c04f7bc2acdee684544ec3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256722
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36328}

rtc_base/openssl_identity.cc

diff --git a/rtc_base/openssl_identity.cc b/rtc_base/openssl_identity.cc
index 3794d98..1864978 100644
--- a/rtc_base/openssl_identity.cc
+++ b/rtc_base/openssl_identity.cc
@@ -70,12 +70,12 @@
 
 // static
 std::unique_ptr<OpenSSLIdentity> OpenSSLIdentity::CreateWithExpiration(
-    const std::string& common_name,
+    absl::string_view common_name,
     const KeyParams& key_params,
     time_t certificate_lifetime) {
   SSLIdentityParams params;
   params.key_params = key_params;
-  params.common_name = common_name;
+  params.common_name = std::string(common_name);
   time_t now = time(nullptr);
   params.not_before = now + kCertificateWindowInSeconds;
   params.not_after = now + certificate_lifetime;
@@ -90,8 +90,8 @@
 }
 
 std::unique_ptr<SSLIdentity> OpenSSLIdentity::CreateFromPEMStrings(
-    const std::string& private_key,
-    const std::string& certificate) {
+    absl::string_view private_key,
+    absl::string_view certificate) {
   std::unique_ptr<OpenSSLCertificate> cert(
       OpenSSLCertificate::FromPEMString(certificate));
   if (!cert) {
@@ -110,8 +110,8 @@
 }
 
 std::unique_ptr<SSLIdentity> OpenSSLIdentity::CreateFromPEMChainStrings(
-    const std::string& private_key,
-    const std::string& certificate_chain) {
+    absl::string_view private_key,
+    absl::string_view certificate_chain) {
   BIO* bio = BIO_new_mem_buf(certificate_chain.data(),
                              rtc::dchecked_cast<int>(certificate_chain.size()));
   if (!bio)