| commit | 62e9ebe5894472de35000e5b7074b31fdc06c728 | [log] [tgz] |
|---|---|---|
| author | Guido Urdaneta <guidou@webrtc.org> | Thu Dec 14 17:01:38 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 14 17:35:53 2017 |
| tree | 2f16ec94e79ef7c5a133360a9b4b9ec323cd8768 | |
| parent | 7284e8a650dc33304c1548a5b5f4b56d32cc1d1c [diff] |
Revert "googBandwidthLimitedResolution stat is not always set depending on configuration." This reverts commit 59283e4c66d038a00923736685457f4b53f922fe. Reason for revert: This CL is preventing rolls into Chromium because it fails to compile with MSVC. Sample error log: [13258/43857] CXX obj/third_party/webrtc/video/video/send_statistics_proxy.obj FAILED: obj/third_party/webrtc/video/video/send_statistics_proxy.obj ninja -t msvc -e environment.x64 -- E:\b\c\goma_client/gomacc.exe "e:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\bin\hostx64\x64/cl.exe" /nologo /showIncludes @obj/third_party/webrtc/video/video/send_statistics_proxy.obj.rsp /c ../../third_party/webrtc/video/send_statistics_proxy.cc /Foobj/third_party/webrtc/video/video/send_statistics_proxy.obj /Fd"obj/third_party/webrtc/video/video_cc.pdb" ../../third_party/webrtc/video/send_statistics_proxy.cc(217): error C2220: warning treated as error - no 'object' file generated ../../third_party/webrtc/video/send_statistics_proxy.cc(217): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data ../../third_party/webrtc/video/send_statistics_proxy.cc(632): warning C4267: '=': conversion from 'size_t' to 'uint32_t', possible loss of data Original change's description: > googBandwidthLimitedResolution stat is not always set depending on configuration. > > Currently |bw_resolutions_disabled| is set per VP8EncoderImpl instance and reported via > OnEncodedImage callback. > > Instead move logic to SendStatisticsProxy to determine if resolution is bw limited or not based > on info that is reported to SendStatisticsProxy::OnEncodedImage. > > Bug: webrtc:8643 > Change-Id: I6c148e3507a0f04a793775b9f84ce54028b64d0f > Reviewed-on: https://webrtc-review.googlesource.com/31460 > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org> > Reviewed-by: Stefan Holmer <stefan@webrtc.org> > Commit-Queue: Åsa Persson <asapersson@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#21249} TBR=brandtr@webrtc.org,asapersson@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8643 Change-Id: Ib9ef55b8894ea72236a5dc1e9a839adecd401afb Reviewed-on: https://webrtc-review.googlesource.com/33100 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21284}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.