Google Git
Sign in
webrtc / src / 63a59de808ba7669e60bded703e71f360e5337e0
commit63a59de808ba7669e60bded703e71f360e5337e0[log] [tgz]
authorVictor Boivie <boivie@webrtc.org>Fri Sep 05 09:05:34 2025
committerWebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 05 12:11:01 2025
tree38ea6c6a56d04563cef4965caaf3763a7082dd8b
parent5b274054af552689fefcb20b08428c2d44fa0354 [diff]
dcsctp: Avoid iterator invalidation

The ExpireOutstandingChunks method iterated through the
`outstanding_data_` container while conditionally calling
`AbandonAllFor`. The `AbandonAllFor` method can, in some cases, add new
elements to `outstanding_data_`, which invalidates the iterators used by
the loop in `ExpireOutstandingChunks`. This could lead to undefined
behavior.

This aligns the C++ implementation to the Rust dcsctp port, which
handles this correctly by using a two-pass approach.

Bug: chromium:443213199
Change-Id: Ib5ac73b743c5ed900a69806088780c213536a4a6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/408002
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Auto-Submit: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45566}
1 file changed
tree: 38ea6c6a56d04563cef4965caaf3763a7082dd8b
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. docs/
  9. examples/
  10. experiments/
  11. g3doc/
  12. infra/
  13. logging/
  14. media/
  15. modules/
  16. net/
  17. p2p/
  18. pc/
  19. resources/
  20. rtc_base/
  21. rtc_tools/
  22. sdk/
  23. stats/
  24. system_wrappers/
  25. test/
  26. tools_webrtc/
  27. video/
  28. .clang-format
  29. .clang-tidy
  30. .git-blame-ignore-revs
  31. .gitignore
  32. .gn
  33. .mailmap
  34. .rustfmt.toml
  35. .style.yapf
  36. .vpython3
  37. AUTHORS
  38. BUILD.gn
  39. CODE_OF_CONDUCT.md
  40. codereview.settings
  41. DEPS
  42. DIR_METADATA
  43. ENG_REVIEW_OWNERS
  44. LICENSE
  45. license_template.txt
  46. native-api.md
  47. OWNERS
  48. OWNERS_INFRA
  49. PATENTS
  50. PRESUBMIT.py
  51. presubmit_test.py
  52. presubmit_test_mocks.py
  53. pylintrc
  54. pylintrc_old_style
  55. README.chromium
  56. README.md
  57. WATCHLISTS
  58. webrtc.gni
  59. webrtc_lib_link_test.cc
  60. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info