Google Git
Sign in
webrtc / src / 63c20e9924e9d49a23b580f44aee1935fc8d6974
commit63c20e9924e9d49a23b580f44aee1935fc8d6974[log] [tgz]
authorShigemasa Watanabe <shigemasa7watanabe@gmail.com>Sat Oct 18 10:18:53 2025
committerWebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Oct 21 10:55:28 2025
tree61e2c3eeba20e3ec7614ef210a5f8580204ac9fc
parent29214344f60cb0033011375f493f5b92c3fce53d [diff]
Ensure that SVC is not enabled when mixed codec is used.

In the mixed-codec simulcast case, send_codec_ cannot correctly retain
the codec-specific settings, so accessing send_codec_.VP9() causes
a crash.

I added a send_codec_.IsMixedCodec() guard to work around this issue.

I also made it an error to enable SVC when using mixed-codec, and added
a test for that.

Bug: webrtc:362277533
Change-Id: I056fc210406d0243332ec28cf1f998ad37384961
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/413740
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45996}
7 files changed
tree: 61e2c3eeba20e3ec7614ef210a5f8580204ac9fc
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. docs/
  9. examples/
  10. experiments/
  11. g3doc/
  12. infra/
  13. logging/
  14. media/
  15. modules/
  16. net/
  17. p2p/
  18. pc/
  19. resources/
  20. rtc_base/
  21. rtc_tools/
  22. sdk/
  23. stats/
  24. system_wrappers/
  25. test/
  26. tools_webrtc/
  27. video/
  28. .clang-format
  29. .clang-tidy
  30. .git-blame-ignore-revs
  31. .gitignore
  32. .gn
  33. .mailmap
  34. .rustfmt.toml
  35. .style.yapf
  36. .vpython3
  37. AUTHORS
  38. BUILD.gn
  39. CODE_OF_CONDUCT.md
  40. codereview.settings
  41. DEPS
  42. DIR_METADATA
  43. ENG_REVIEW_OWNERS
  44. LICENSE
  45. license_template.txt
  46. native-api.md
  47. OWNERS
  48. OWNERS_INFRA
  49. PATENTS
  50. PRESUBMIT.py
  51. presubmit_test.py
  52. presubmit_test_mocks.py
  53. pylintrc
  54. pylintrc_old_style
  55. README.chromium
  56. README.md
  57. WATCHLISTS
  58. webrtc.gni
  59. webrtc_lib_link_test.cc
  60. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info