Fix clang style warnings in webrtc/base
Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
diff --git a/webrtc/base/fileutils.h b/webrtc/base/fileutils.h
index 9112952..1533fb5 100644
--- a/webrtc/base/fileutils.h
+++ b/webrtc/base/fileutils.h
@@ -95,9 +95,7 @@
// Returns a DirectoryIterator for a given pathname.
// TODO: Do fancy abstracted stuff
- virtual DirectoryIterator *IterateDirectory() {
- return new DirectoryIterator();
- }
+ virtual DirectoryIterator* IterateDirectory();
// Opens a file. Returns an open StreamInterface if function succeeds.
// Otherwise, returns NULL.
@@ -133,9 +131,7 @@
// This deletes the contents of a folder, recursively, and then deletes
// the folder itself.
- virtual bool DeleteFolderAndContents(const Pathname &folder) {
- return DeleteFolderContents(folder) && DeleteEmptyFolder(folder);
- }
+ virtual bool DeleteFolderAndContents(const Pathname& folder);
// This will delete whatever is located at path, be it a file or a folder.
// If it is a folder, it will delete it recursively by calling
