Change rtc event log packet messages implementation to save full rtp packet
Keeping just the header doesn't save memory because header is taken as slice
of the original packet (and thus keeps a reference to the buffer containing
full packet)
Keeping full packet is simpler and avoid extra unused buffer created during
RtpPacket default contruction
Bug: b/187593466
Change-Id: I78d7201d110092fc039203e1caa2fb9c3afbc079
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218161
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33974}
diff --git a/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.h b/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.h
index 3105dc1..37296e7 100644
--- a/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.h
+++ b/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.h
@@ -15,6 +15,7 @@
#include <memory>
#include <string>
+#include "api/array_view.h"
#include "logging/rtc_event_log/encoder/rtc_event_log_encoder.h"
#include "rtc_base/buffer.h"
@@ -94,7 +95,7 @@
const rtc::Buffer& packet,
bool is_incoming);
std::string EncodeRtpPacket(int64_t timestamp_us,
- const RtpPacket& header,
+ rtc::ArrayView<const uint8_t> header,
size_t packet_length,
int probe_cluster_id,
bool is_incoming);