Include-what-you-use rtc_base/numerics/
Bug: webrtc:42226242
Change-Id: Ib59078d67af20fa44d79d1a9338b1a3ca6e4c6d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/354463
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42492}
diff --git a/rtc_base/BUILD.gn b/rtc_base/BUILD.gn
index 85ec8edb..5405241 100644
--- a/rtc_base/BUILD.gn
+++ b/rtc_base/BUILD.gn
@@ -818,6 +818,7 @@
"numerics/sample_stats.h",
]
deps = [
+ ":checks",
"../api/numerics",
"../api/units:data_rate",
"../api/units:time_delta",
@@ -2078,11 +2079,13 @@
"numerics/sequence_number_util_unittest.cc",
]
deps = [
+ ":mod_ops",
":rtc_numerics",
":timeutils",
"../test:test_main",
"../test:test_support",
"//third_party/abseil-cpp/absl/algorithm:container",
+ "//third_party/abseil-cpp/absl/types:optional",
]
}
diff --git a/rtc_base/numerics/divide_round_unittest.cc b/rtc_base/numerics/divide_round_unittest.cc
index 00548e1..c0934e6 100644
--- a/rtc_base/numerics/divide_round_unittest.cc
+++ b/rtc_base/numerics/divide_round_unittest.cc
@@ -10,7 +10,9 @@
#include "rtc_base/numerics/divide_round.h"
+#include <cstdint>
#include <limits>
+#include <type_traits>
#include "test/gtest.h"
diff --git a/rtc_base/numerics/event_based_exponential_moving_average.cc b/rtc_base/numerics/event_based_exponential_moving_average.cc
index b426fde..048eb0d 100644
--- a/rtc_base/numerics/event_based_exponential_moving_average.cc
+++ b/rtc_base/numerics/event_based_exponential_moving_average.cc
@@ -11,6 +11,8 @@
#include "rtc_base/numerics/event_based_exponential_moving_average.h"
#include <cmath>
+#include <cstdint>
+#include <limits>
#include "rtc_base/checks.h"
diff --git a/rtc_base/numerics/event_based_exponential_moving_average_unittest.cc b/rtc_base/numerics/event_based_exponential_moving_average_unittest.cc
index 967be41..89d9c5f 100644
--- a/rtc_base/numerics/event_based_exponential_moving_average_unittest.cc
+++ b/rtc_base/numerics/event_based_exponential_moving_average_unittest.cc
@@ -11,6 +11,8 @@
#include "rtc_base/numerics/event_based_exponential_moving_average.h"
#include <cmath>
+#include <cstdint>
+#include <limits>
#include "test/gtest.h"
diff --git a/rtc_base/numerics/event_rate_counter.cc b/rtc_base/numerics/event_rate_counter.cc
index d7b7293..52c9de6 100644
--- a/rtc_base/numerics/event_rate_counter.cc
+++ b/rtc_base/numerics/event_rate_counter.cc
@@ -10,6 +10,10 @@
#include "rtc_base/numerics/event_rate_counter.h"
#include <algorithm>
+#include <cmath>
+
+#include "api/units/time_delta.h"
+#include "api/units/timestamp.h"
namespace webrtc {
diff --git a/rtc_base/numerics/event_rate_counter.h b/rtc_base/numerics/event_rate_counter.h
index 60ec3ba..ef107ba 100644
--- a/rtc_base/numerics/event_rate_counter.h
+++ b/rtc_base/numerics/event_rate_counter.h
@@ -10,6 +10,10 @@
#ifndef RTC_BASE_NUMERICS_EVENT_RATE_COUNTER_H_
#define RTC_BASE_NUMERICS_EVENT_RATE_COUNTER_H_
+#include <cstdint>
+
+#include "api/units/time_delta.h"
+#include "api/units/timestamp.h"
#include "rtc_base/numerics/sample_stats.h"
namespace webrtc {
diff --git a/rtc_base/numerics/histogram_percentile_counter.cc b/rtc_base/numerics/histogram_percentile_counter.cc
index 29d2341..498bb4b 100644
--- a/rtc_base/numerics/histogram_percentile_counter.cc
+++ b/rtc_base/numerics/histogram_percentile_counter.cc
@@ -12,7 +12,10 @@
#include <algorithm>
#include <cmath>
+#include <cstddef>
+#include <cstdint>
+#include "absl/types/optional.h"
#include "rtc_base/checks.h"
namespace rtc {
diff --git a/rtc_base/numerics/moving_average.cc b/rtc_base/numerics/moving_average.cc
index c825839..126223e 100644
--- a/rtc_base/numerics/moving_average.cc
+++ b/rtc_base/numerics/moving_average.cc
@@ -11,7 +11,10 @@
#include "rtc_base/numerics/moving_average.h"
#include <algorithm>
+#include <cstddef>
+#include <cstdint>
+#include "absl/types/optional.h"
#include "rtc_base/checks.h"
namespace rtc {
diff --git a/rtc_base/numerics/moving_average_unittest.cc b/rtc_base/numerics/moving_average_unittest.cc
index 9bc9a1a..5993401 100644
--- a/rtc_base/numerics/moving_average_unittest.cc
+++ b/rtc_base/numerics/moving_average_unittest.cc
@@ -10,6 +10,7 @@
#include "rtc_base/numerics/moving_average.h"
+#include "absl/types/optional.h"
#include "test/gtest.h"
namespace test {
diff --git a/rtc_base/numerics/moving_percentile_filter_unittest.cc b/rtc_base/numerics/moving_percentile_filter_unittest.cc
index 30c0ebb..f456108 100644
--- a/rtc_base/numerics/moving_percentile_filter_unittest.cc
+++ b/rtc_base/numerics/moving_percentile_filter_unittest.cc
@@ -13,6 +13,7 @@
#include <stdint.h>
#include <algorithm>
+#include <cstddef>
#include "test/gtest.h"
diff --git a/rtc_base/numerics/running_statistics.h b/rtc_base/numerics/running_statistics.h
index fe991b0..134b895 100644
--- a/rtc_base/numerics/running_statistics.h
+++ b/rtc_base/numerics/running_statistics.h
@@ -13,7 +13,7 @@
#include <algorithm>
#include <cmath>
-#include <limits>
+#include <cstdint>
#include "absl/types/optional.h"
#include "rtc_base/checks.h"
diff --git a/rtc_base/numerics/safe_compare.h b/rtc_base/numerics/safe_compare.h
index 85f0a30..d3d918d 100644
--- a/rtc_base/numerics/safe_compare.h
+++ b/rtc_base/numerics/safe_compare.h
@@ -35,7 +35,6 @@
#include <stdint.h>
#include <type_traits>
-#include <utility>
#include "rtc_base/type_traits.h"
diff --git a/rtc_base/numerics/safe_compare_unittest.cc b/rtc_base/numerics/safe_compare_unittest.cc
index 92bde68..e7e0e0b 100644
--- a/rtc_base/numerics/safe_compare_unittest.cc
+++ b/rtc_base/numerics/safe_compare_unittest.cc
@@ -10,7 +10,9 @@
#include "rtc_base/numerics/safe_compare.h"
+#include <cstdint>
#include <limits>
+#include <utility>
#include "test/gtest.h"
diff --git a/rtc_base/numerics/safe_minmax.h b/rtc_base/numerics/safe_minmax.h
index 8356536..cdb6da2 100644
--- a/rtc_base/numerics/safe_minmax.h
+++ b/rtc_base/numerics/safe_minmax.h
@@ -76,6 +76,7 @@
#ifndef RTC_BASE_NUMERICS_SAFE_MINMAX_H_
#define RTC_BASE_NUMERICS_SAFE_MINMAX_H_
+#include <cstdint>
#include <limits>
#include <type_traits>
diff --git a/rtc_base/numerics/safe_minmax_unittest.cc b/rtc_base/numerics/safe_minmax_unittest.cc
index c52b3f9..2aa0221 100644
--- a/rtc_base/numerics/safe_minmax_unittest.cc
+++ b/rtc_base/numerics/safe_minmax_unittest.cc
@@ -11,7 +11,9 @@
#include "rtc_base/numerics/safe_minmax.h"
#include <algorithm>
+#include <cstdint>
#include <limits>
+#include <type_traits>
#include "test/gtest.h"
diff --git a/rtc_base/numerics/sample_counter.cc b/rtc_base/numerics/sample_counter.cc
index 78e35fd..5e63b97 100644
--- a/rtc_base/numerics/sample_counter.cc
+++ b/rtc_base/numerics/sample_counter.cc
@@ -10,8 +10,10 @@
#include "rtc_base/numerics/sample_counter.h"
+#include <cstdint>
#include <limits>
+#include "absl/types/optional.h"
#include "rtc_base/checks.h"
#include "rtc_base/numerics/safe_conversions.h"
diff --git a/rtc_base/numerics/sample_counter_unittest.cc b/rtc_base/numerics/sample_counter_unittest.cc
index ffc8b89..6877f5e 100644
--- a/rtc_base/numerics/sample_counter_unittest.cc
+++ b/rtc_base/numerics/sample_counter_unittest.cc
@@ -12,6 +12,7 @@
#include <initializer_list>
+#include "absl/types/optional.h"
#include "test/gmock.h"
#include "test/gtest.h"
diff --git a/rtc_base/numerics/sample_stats.cc b/rtc_base/numerics/sample_stats.cc
index 6000b2b..606b1b6 100644
--- a/rtc_base/numerics/sample_stats.cc
+++ b/rtc_base/numerics/sample_stats.cc
@@ -9,6 +9,12 @@
*/
#include "rtc_base/numerics/sample_stats.h"
+#include <cmath>
+
+#include "api/units/data_rate.h"
+#include "api/units/time_delta.h"
+#include "rtc_base/checks.h"
+
namespace webrtc {
double SampleStats<double>::Max() {
diff --git a/rtc_base/numerics/sample_stats.h b/rtc_base/numerics/sample_stats.h
index 39af1c6..11a884b 100644
--- a/rtc_base/numerics/sample_stats.h
+++ b/rtc_base/numerics/sample_stats.h
@@ -13,7 +13,6 @@
#include "api/numerics/samples_stats_counter.h"
#include "api/units/data_rate.h"
#include "api/units/time_delta.h"
-#include "api/units/timestamp.h"
namespace webrtc {
template <typename T>
diff --git a/rtc_base/numerics/sequence_number_unwrapper.h b/rtc_base/numerics/sequence_number_unwrapper.h
index d741b5c..fb21283 100644
--- a/rtc_base/numerics/sequence_number_unwrapper.h
+++ b/rtc_base/numerics/sequence_number_unwrapper.h
@@ -14,6 +14,7 @@
#include <stdint.h>
#include <limits>
+#include <type_traits>
#include "absl/types/optional.h"
#include "rtc_base/numerics/sequence_number_util.h"
diff --git a/rtc_base/numerics/sequence_number_unwrapper_unittest.cc b/rtc_base/numerics/sequence_number_unwrapper_unittest.cc
index fcd903b..10ffecb 100644
--- a/rtc_base/numerics/sequence_number_unwrapper_unittest.cc
+++ b/rtc_base/numerics/sequence_number_unwrapper_unittest.cc
@@ -11,6 +11,7 @@
#include "rtc_base/numerics/sequence_number_unwrapper.h"
#include <cstdint>
+#include <limits>
#include "test/gtest.h"
diff --git a/rtc_base/numerics/sequence_number_util.h b/rtc_base/numerics/sequence_number_util.h
index 702b82f..0eafaa8 100644
--- a/rtc_base/numerics/sequence_number_util.h
+++ b/rtc_base/numerics/sequence_number_util.h
@@ -11,7 +11,6 @@
#ifndef RTC_BASE_NUMERICS_SEQUENCE_NUMBER_UTIL_H_
#define RTC_BASE_NUMERICS_SEQUENCE_NUMBER_UTIL_H_
-#include <stdint.h>
#include <limits>
#include <type_traits>
diff --git a/rtc_base/numerics/sequence_number_util_unittest.cc b/rtc_base/numerics/sequence_number_util_unittest.cc
index d44127b..f23c106 100644
--- a/rtc_base/numerics/sequence_number_util_unittest.cc
+++ b/rtc_base/numerics/sequence_number_util_unittest.cc
@@ -14,6 +14,7 @@
#include <iterator>
#include <set>
+#include "rtc_base/numerics/mod_ops.h"
#include "test/gtest.h"
namespace webrtc {
