[Bug fix] Update all state in AudioProcessing::ApplyConfig

APM initialization has a cyclic dependency:
* the state of submodule_states_ depends on submodules_
* the state of formats_ depends on submodule_states_
* the state of submodules_ depends on submodule_states_ and formats_

This usually works out because:
* submodule_states_ starts in a valid state
* submodule_states_ is updated frequently, and
* capture_nonlocked_.echo_controller_enabled "covers up" when submodule_states_ is out of sync.

However, ApplyConfig and ProcessReverseStream don't update submodule_states_, so some API call orderings put APM in an invalid state.

This CL fixes it by deleting capture_nonlocked_.echo_controller_enabled and properly updating submodule_states_ from ApplyConfig().

Tested: New unit test, old unit tests, and audioproc_f is bitexact on my test set of aecdumps.
Bug: b/452621275
Change-Id: I735aa9a842edfa2a54ae271e121fd809bc59e6c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/417782
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45972}
4 files changed
tree: 680d8eb6d664ef2a5f4f92229b997b6b86bae8f7
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. docs/
  9. examples/
  10. experiments/
  11. g3doc/
  12. infra/
  13. logging/
  14. media/
  15. modules/
  16. net/
  17. p2p/
  18. pc/
  19. resources/
  20. rtc_base/
  21. rtc_tools/
  22. sdk/
  23. stats/
  24. system_wrappers/
  25. test/
  26. tools_webrtc/
  27. video/
  28. .clang-format
  29. .clang-tidy
  30. .git-blame-ignore-revs
  31. .gitignore
  32. .gn
  33. .mailmap
  34. .rustfmt.toml
  35. .style.yapf
  36. .vpython3
  37. AUTHORS
  38. BUILD.gn
  39. CODE_OF_CONDUCT.md
  40. codereview.settings
  41. DEPS
  42. DIR_METADATA
  43. ENG_REVIEW_OWNERS
  44. LICENSE
  45. license_template.txt
  46. native-api.md
  47. OWNERS
  48. OWNERS_INFRA
  49. PATENTS
  50. PRESUBMIT.py
  51. presubmit_test.py
  52. presubmit_test_mocks.py
  53. pylintrc
  54. pylintrc_old_style
  55. README.chromium
  56. README.md
  57. WATCHLISTS
  58. webrtc.gni
  59. webrtc_lib_link_test.cc
  60. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info