| commit | 7add207ada479c4b9087fec2178ece9086523dc6 | [log] [tgz] |
|---|---|---|
| author | Lambros Lambrou <lambroslambrou@chromium.org> | Thu Sep 02 06:58:50 2021 |
| committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 02 17:33:16 2021 |
| tree | b5ea2d2a7856b08adbcbe6707a7555ac29612b54 | |
| parent | 3c9f41d4efc150bf8a43656bb66ea32de69ef2f0 [diff] |
Remove DCHECK when overwriting shared DesktopFrame. The desktop capturer uses a circular queue (currently of length 2) to implement a double-buffer scheme. This allows a C++ API consumer to keep a reference to the latest captured image without the pixels being overwritten by a pending capture request. The DCHECK was intended to warn that the application is still holding a reference to a recycled frame that is being captured into. This made sense when the capturer implementations were originally part of the Chromoting host process. Now that the capturers are part of the WebRTC C++ library, a DCHECK seems too harsh. A DCHECK should be reserved for impossible conditions, but this one triggers simply because an API consumer holds onto a reference for too long. This CL changes these DCHECKs into log warnings. The DCHECK is sometimes triggered by the Chromoting host process (because of the recent change to use the standard encoding pipeline). This is tracked by http://crbug.com/1239746. Bug: None Change-Id: Iad9ef38b4800315bd17c93b27d287e115d4fe54c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/230881 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/main@{#34910}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.