Google Git
Sign in
webrtc / src / 7b167fbace1a6c5cabe453d08670d5f41ec8fafe
commit7b167fbace1a6c5cabe453d08670d5f41ec8fafe[log] [tgz]
authorTommi <tommi@webrtc.org>Fri Oct 03 07:33:55 2025
committerWebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 03 09:53:34 2025
tree104ae6c9d9cbed98d49cbeb8c630d3f4f9dba6a9
parent1b1b76e43b25727dbddc63c7daac8db3c5419899 [diff]
Move IceCandidate::Create to api/ and break cyclical pc/ dependency

The static IceCandidate::Create function was previously implemented in
pc/jsep_ice_candidate.cc. This created an unwanted dependency from the
api/ target to the pc/ target, which in turn depended on api/. This
patch moves the function to api/jsep_ice_candidate.cc, resolving this.

To make the move possible, the implementation now uses
Candidate::ParseCandidateString instead of relying on the ParseCandidate
helper function from pc/webrtc_sdp.cc.

The now-redundant SDP candidate parsing logic is removed from
pc/webrtc_sdp.cc. ParseCandidate, now just wraps
Candidate::ParseCandidateString but functions as before. This also
removes the VerifyResults DCHECK class that was used to ensure
equivalency between the two parsing implementations.

Bug: webrtc:12330
Change-Id: I2061bf125b45168b06445aba34bad72e2d557de4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/411200
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45816}
4 files changed
tree: 104ae6c9d9cbed98d49cbeb8c630d3f4f9dba6a9
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. docs/
  9. examples/
  10. experiments/
  11. g3doc/
  12. infra/
  13. logging/
  14. media/
  15. modules/
  16. net/
  17. p2p/
  18. pc/
  19. resources/
  20. rtc_base/
  21. rtc_tools/
  22. sdk/
  23. stats/
  24. system_wrappers/
  25. test/
  26. tools_webrtc/
  27. video/
  28. .clang-format
  29. .clang-tidy
  30. .git-blame-ignore-revs
  31. .gitignore
  32. .gn
  33. .mailmap
  34. .rustfmt.toml
  35. .style.yapf
  36. .vpython3
  37. AUTHORS
  38. BUILD.gn
  39. CODE_OF_CONDUCT.md
  40. codereview.settings
  41. DEPS
  42. DIR_METADATA
  43. ENG_REVIEW_OWNERS
  44. LICENSE
  45. license_template.txt
  46. native-api.md
  47. OWNERS
  48. OWNERS_INFRA
  49. PATENTS
  50. PRESUBMIT.py
  51. presubmit_test.py
  52. presubmit_test_mocks.py
  53. pylintrc
  54. pylintrc_old_style
  55. README.chromium
  56. README.md
  57. WATCHLISTS
  58. webrtc.gni
  59. webrtc_lib_link_test.cc
  60. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info