Google Git
Sign in
webrtc / src / 7e2d80c04d086e495110faa48ea71863434914ee
commit7e2d80c04d086e495110faa48ea71863434914ee[log] [tgz]
authorTommi <tommi@webrtc.org>Mon Oct 06 06:26:09 2025
committerWebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Oct 06 12:39:30 2025
tree3a9c1921e6a0a96c19d7d9e6496343ba3414bb15
parentea35b634214056c47c14e5052c2a2f6de8b97aab [diff]
Consolidate the IceCandidate implementation

The IceCandidate implementation was previously split into two source
files: `api/jsep_ice_candidate.cc` and `pc/jsep_ice_candidate.cc`. Due
to cyclic dependencies, the `pc/` file was needed to house
implementations that depended on functionality in webrtc_sdp.

Now that the cyclical dependency has been fixed, this CL resolves the
TODO noted in webrtc:42222470 by merging these split implementations and
deleting `pc/jsep_ice_candidate.cc`.

* `IceCandidateCollection::Clone` moves to
  `api/jsep_ice_candidate.cc` where other
   IceCandidateCollection methods are.
* The `CreateIceCandidate` helper functions move to `api/jsep.cc`,
  matching the header file where they're declared.
* `pc/jsep_ice_candidate.cc` is removed.

Bug: webrtc:42222470
Change-Id: I3b1e871fddfe8e15b47062ae4d45389130c098e5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/411020
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45835}
4 files changed
tree: 3a9c1921e6a0a96c19d7d9e6496343ba3414bb15
  1. api/
  2. audio/
  3. build_overrides/
  4. call/
  5. common_audio/
  6. common_video/
  7. data/
  8. docs/
  9. examples/
  10. experiments/
  11. g3doc/
  12. infra/
  13. logging/
  14. media/
  15. modules/
  16. net/
  17. p2p/
  18. pc/
  19. resources/
  20. rtc_base/
  21. rtc_tools/
  22. sdk/
  23. stats/
  24. system_wrappers/
  25. test/
  26. tools_webrtc/
  27. video/
  28. .clang-format
  29. .clang-tidy
  30. .git-blame-ignore-revs
  31. .gitignore
  32. .gn
  33. .mailmap
  34. .rustfmt.toml
  35. .style.yapf
  36. .vpython3
  37. AUTHORS
  38. BUILD.gn
  39. CODE_OF_CONDUCT.md
  40. codereview.settings
  41. DEPS
  42. DIR_METADATA
  43. ENG_REVIEW_OWNERS
  44. LICENSE
  45. license_template.txt
  46. native-api.md
  47. OWNERS
  48. OWNERS_INFRA
  49. PATENTS
  50. PRESUBMIT.py
  51. presubmit_test.py
  52. presubmit_test_mocks.py
  53. pylintrc
  54. pylintrc_old_style
  55. README.chromium
  56. README.md
  57. WATCHLISTS
  58. webrtc.gni
  59. webrtc_lib_link_test.cc
  60. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info