| commit | 7ec990de37b47c86f9707e55b675cea8cd191b4a | [log] [tgz] |
|---|---|---|
| author | Artem Titov <titovartem@google.com> | Thu Nov 18 14:34:02 2021 |
| committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Nov 18 15:05:05 2021 |
| tree | bb96ef00772b61756d5dff4949ff2a17e86a9523 | |
| parent | 50b95525c7464020e2d5ed45a721e7197d8b71bd [diff] |
Fix flakky test: ensure that DVQA was executed for some time. It will ensure that clock moved forward, so clock related metrics as CPU usage will be also calculated correctly. We should dig into it deeper to fix the root cause later. Example failure: https://ci.chromium.org/ui/p/webrtc/builders/try/win_asan/44610/overview Bug: b/205824594 Change-Id: If1ebcf6a2b88ba0054479be292cca8f50506e741 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238381 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35379}
diff --git a/test/pc/e2e/analyzer/video/default_video_quality_analyzer_test.cc b/test/pc/e2e/analyzer/video/default_video_quality_analyzer_test.cc index b18457e..792aa33 100644 --- a/test/pc/e2e/analyzer/video/default_video_quality_analyzer_test.cc +++ b/test/pc/e2e/analyzer/video/default_video_quality_analyzer_test.cc
@@ -1459,6 +1459,11 @@ VideoQualityAnalyzerInterface::EncoderStats()); } // We don't need to receive frames for stats to be gathered correctly. + + // Give analyzer some time to process frames on async thread. The computations + // have to be fast (heavy metrics are disabled!), so if doesn't fit 100ms it + // means we have an issue! + SleepMs(100); analyzer.Stop(); EXPECT_EQ(analyzer.GetStreamFrames(), stream_to_frame_ids);