| commit | 839439ae844b89220e39b1f56f4d914a32105b7b | [log] [tgz] |
|---|---|---|
| author | Henrik Boström <hbos@webrtc.org> | Tue Sep 06 09:16:36 2022 |
| committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 07 07:23:49 2022 |
| tree | 89ae802ddef3f8deb7f4298f4359cf6e716cb50b | |
| parent | 808b951ab9763ac5fba115d8c1cddc164ee91c5c [diff] |
RTCIceCandidatePairStats.requestsSent should be total pings. The spec says: "Represents the total number of connectivity check requests sent (not including retransmissions)." I was surprised to find candidate-pair.requestsSent wired up to `sent_ping_requests_before_first_response`, which is the subset of `sent_ping_requests_total` that happened when `recv_ping_responses` was 0. This is not what the spec says. By wiring it up to `sent_ping_requests_total` instead, the modern getStats implementation of "requestsSent" will match the legacy getStats implementation which is already wired up to this value. // Unrelated bot issues NOTRY=True Bug: webrtc:14425 Change-Id: Ia53c9711ee7a13e596ae0eacf6066b97d9a1face Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274174 Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38025}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.