commit 87b3c510b4eb156575f30c6ff2e100727e54b10f
author Florent Castelli <orphis@webrtc.org> Wed Jul 18 14:00:28 2018
committer Commit Bot <commit-bot@chromium.org> Wed Jul 18 14:45:27 2018
tree 02fee6474bbacba77d3da0bd958f4ae069570a25
parent a61f7db9ae5a19737a6ce67678b40ee724e5b971

Implement changing degradation preference with setParameters()

The current default behavior is unchanged and points to MAINTAIN_FRAMERATE,
meaning there is no way to currently use BALANCED as we can't detect
when the value as been set or not.
Updating this is an API change that should be done in another CL and
properly communicated first.


Bug: webrtc:7607
Change-Id: Ic3877ad8dd7bc418296f21a04bc37f59ec55934a
Reviewed-on: https://webrtc-review.googlesource.com/88766
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24024}

pc/rtpsenderreceiver_unittest.cc

diff --git a/pc/rtpsenderreceiver_unittest.cc b/pc/rtpsenderreceiver_unittest.cc
index 3e0488d..4014df5 100644
--- a/pc/rtpsenderreceiver_unittest.cc
+++ b/pc/rtpsenderreceiver_unittest.cc
@@ -675,18 +675,12 @@
   RtpParameters params = audio_rtp_sender_->GetParameters();
   EXPECT_EQ(1u, params.encodings.size());
 
-  // Unimplemented RtpParameters: mid, header_extensions,
-  // degredation_preference.
+  // Unimplemented RtpParameters: mid
   params.mid = "dummy_mid";
   EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
             audio_rtp_sender_->SetParameters(params).type());
   params = audio_rtp_sender_->GetParameters();
 
-  ASSERT_EQ(DegradationPreference::BALANCED, params.degradation_preference);
-  params.degradation_preference = DegradationPreference::MAINTAIN_FRAMERATE;
-  EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
-            audio_rtp_sender_->SetParameters(params).type());
-
   DestroyAudioRtpSender();
 }
 
@@ -868,18 +862,12 @@
   RtpParameters params = video_rtp_sender_->GetParameters();
   EXPECT_EQ(1u, params.encodings.size());
 
-  // Unimplemented RtpParameters: mid, header_extensions,
-  // degredation_preference.
+  // Unimplemented RtpParameters: mid
   params.mid = "dummy_mid";
   EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
             video_rtp_sender_->SetParameters(params).type());
   params = video_rtp_sender_->GetParameters();
 
-  ASSERT_EQ(DegradationPreference::BALANCED, params.degradation_preference);
-  params.degradation_preference = DegradationPreference::MAINTAIN_FRAMERATE;
-  EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
-            video_rtp_sender_->SetParameters(params).type());
-
   DestroyVideoRtpSender();
 }