commit 90e1f539a5fc0e081720a424b9acd54cbcb08b62
author Danil Chapovalov <danilchap@webrtc.org> Tue Oct 03 12:59:27 2017
committer Commit Bot <commit-bot@chromium.org> Tue Oct 03 16:15:33 2017
tree 544c12c836f303f6bbac87d0989e5b0e7406d681
parent c3fa8e1ce7dd3ab90249ca7eb41ab3a975dd448d

Fix potentional race in AudioSendStream constructor

RegisterPacketFeedbackObserver signals congestion controller object is
ready to process incoming packet, thus call it as last statement in the constructor

Bug: webrtc:8325
Change-Id: I31d8ab04c568e639db12c97b649c2d50a489ce24
Reviewed-on: https://webrtc-review.googlesource.com/5860
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20121}

audio/audio_send_stream.cc

diff --git a/audio/audio_send_stream.cc b/audio/audio_send_stream.cc
index 997c95e..62620a4 100644
--- a/audio/audio_send_stream.cc
+++ b/audio/audio_send_stream.cc
@@ -106,7 +106,6 @@
   channel_proxy_->SetRtcEventLog(event_log_);
   channel_proxy_->SetRtcpRttStats(rtcp_rtt_stats);
   channel_proxy_->SetRTCPStatus(true);
-  transport_->send_side_cc()->RegisterPacketFeedbackObserver(this);
   RtpReceiver* rtpReceiver = nullptr;  // Unused, but required for call.
   channel_proxy_->GetRtpRtcp(&rtp_rtcp_module_, &rtpReceiver);
   RTC_DCHECK(rtp_rtcp_module_);
@@ -114,6 +113,8 @@
   ConfigureStream(this, config, true);
 
   pacer_thread_checker_.DetachFromThread();
+  // Signal congestion controller this object is ready for OnPacket* callbacks.
+  transport_->send_side_cc()->RegisterPacketFeedbackObserver(this);
 }
 
 AudioSendStream::~AudioSendStream() {