Use absl::make_unique and absl::WrapUnique directly
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
diff --git a/logging/BUILD.gn b/logging/BUILD.gn
index 66c87b9..8354d73 100644
--- a/logging/BUILD.gn
+++ b/logging/BUILD.gn
@@ -68,6 +68,7 @@
":rtc_event_log_api",
"../:typedefs",
"../rtc_base:ptr_util",
+ "//third_party/abseil-cpp/absl/memory",
]
}
@@ -88,6 +89,7 @@
":rtc_stream_config",
"../modules/audio_coding:audio_network_adaptor_config",
"../rtc_base:ptr_util",
+ "//third_party/abseil-cpp/absl/memory",
]
}
@@ -109,6 +111,7 @@
":rtc_event_log_api",
"../modules/remote_bitrate_estimator:remote_bitrate_estimator",
"../rtc_base:ptr_util",
+ "//third_party/abseil-cpp/absl/memory",
]
}
@@ -130,6 +133,7 @@
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:ptr_util",
"../rtc_base:rtc_base_approved",
+ "//third_party/abseil-cpp/absl/memory",
]
}
@@ -145,6 +149,7 @@
":rtc_event_log_api",
":rtc_stream_config",
"../rtc_base:ptr_util",
+ "//third_party/abseil-cpp/absl/memory",
]
}
@@ -225,6 +230,7 @@
"../rtc_base:rtc_task_queue",
"../rtc_base:safe_minmax",
"../rtc_base:sequenced_task_checker",
+ "//third_party/abseil-cpp/absl/memory",
]
if (rtc_enable_protobuf) {
@@ -296,6 +302,7 @@
"../rtc_base:checks",
"../rtc_base:protobuf_utils",
"../rtc_base:rtc_base_approved",
+ "//third_party/abseil-cpp/absl/memory",
]
if (!build_with_chromium && is_clang) {
@@ -345,6 +352,7 @@
"../test:fileutils",
"../test:test_support",
"//testing/gtest",
+ "//third_party/abseil-cpp/absl/memory",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
@@ -437,6 +445,7 @@
":rtc_event_log_api",
"../api:libjingle_logging_api",
"../rtc_base:rtc_base_approved",
+ "//third_party/abseil-cpp/absl/memory",
]
if (!build_with_chromium && is_clang) {