commit 968995374993687549539d19acbb027fa67f48fa
author Joachim Reiersen <joachimr@meta.com> Tue Jul 08 21:55:40 2025
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jul 09 17:05:08 2025
tree 0aa9c39aa0afad2750bc27d112bd4d4822324351
parent a084fd66f2b6a20485b714a6ad52e157ffb0690e

Fix inadvertent global variables in RTCVideoEncoderFactoryFake

A minor test issue caught by a linter, based on the underscore-prefixed
naming these were intended to be instance variables, not global.

Change-Id: I0f64ed2d0254236df1da943009058fe08b7c0a3f
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/399720
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Joachim Reiersen <joachimr@meta.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45128}

sdk/objc/unittests/objc_video_encoder_factory_tests.mm

diff --git a/sdk/objc/unittests/objc_video_encoder_factory_tests.mm b/sdk/objc/unittests/objc_video_encoder_factory_tests.mm
index 91dcff7..12b9c99 100644
--- a/sdk/objc/unittests/objc_video_encoder_factory_tests.mm
+++ b/sdk/objc/unittests/objc_video_encoder_factory_tests.mm
@@ -67,10 +67,11 @@
                        isPowerEfficient:(bool)isPowerEfficient
     NS_DESIGNATED_INITIALIZER;
 @end
-@implementation RTCVideoEncoderFactoryFake
 
-NSString *_scalabilityMode;
-bool _isPowerEfficient;
+@implementation RTCVideoEncoderFactoryFake {
+  NSString *_scalabilityMode;
+  bool _isPowerEfficient;
+}
 
 - (instancetype)initWithScalabilityMode:(NSString *)scalabilityMode {
   return [self initWithScalabilityMode:scalabilityMode isPowerEfficient:false];