commit 9f6ff832d99ae697de34640b0d348983d908604c
author mmorrison <mmorrison@nvidia.com> Tue Apr 07 21:45:22 2020
committer Commit Bot <commit-bot@chromium.org> Thu Apr 09 11:43:14 2020
tree 99066f180f238faaba872222936b6aa5075180e5
parent 7db1491a85f63441bf8283a5faa658c8886dd249

Do not trigger -Wimplicit-int-float-conversion
This is mentioned in bug 10893 (comment 5).

clang 10.0.0 compiler triggered a warning pointing to the
changed lines. The issue there is the implicit conversion
that takes place in the comparison between 'result' and the max value,
which will result in a change of value for the cast operand.
This is expected, therefore explicitly cast the said constants
in order to make clear the intent and prevent such warnings from
popping up in the future.

Bug: webrtc:10893
Change-Id: Icb5cde84d1a5c7b5e4f4cd4b7b923de894cede87
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173140
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31041}

system_wrappers/include/ntp_time.h

diff --git a/system_wrappers/include/ntp_time.h b/system_wrappers/include/ntp_time.h
index 1f57558..332f8f4 100644
--- a/system_wrappers/include/ntp_time.h
+++ b/system_wrappers/include/ntp_time.h
@@ -70,11 +70,15 @@
   double result =
       std::round(milliseconds * (NtpTime::kFractionsPerSecond / 1000.0));
 
-  if (result <= std::numeric_limits<int64_t>::min()) {
+  // Explicitly cast values to double to avoid implicit conversion warnings
+  // The conversion of the std::numeric_limits<int64_t>::max() triggers
+  // -Wimplicit-int-float-conversion warning in clang 10.0.0 without explicit
+  // cast
+  if (result <= static_cast<double>(std::numeric_limits<int64_t>::min())) {
     return std::numeric_limits<int64_t>::min();
   }
 
-  if (result >= std::numeric_limits<int64_t>::max()) {
+  if (result >= static_cast<double>(std::numeric_limits<int64_t>::max())) {
     return std::numeric_limits<int64_t>::max();
   }
 
@@ -89,11 +93,15 @@
   double result =
       std::round(milliseconds * (NtpTime::kFractionsPerSecond / 1000.0));
 
-  if (result <= std::numeric_limits<uint64_t>::min()) {
+  // Explicitly cast values to double to avoid implicit conversion warnings
+  // The conversion of the std::numeric_limits<int64_t>::max() triggers
+  // -Wimplicit-int-float-conversion warning in clang 10.0.0 without explicit
+  // cast
+  if (result <= static_cast<double>(std::numeric_limits<uint64_t>::min())) {
     return std::numeric_limits<uint64_t>::min();
   }
 
-  if (result >= std::numeric_limits<uint64_t>::max()) {
+  if (result >= static_cast<double>(std::numeric_limits<uint64_t>::max())) {
     return std::numeric_limits<uint64_t>::max();
   }