commit 8be4bc38d9d34da999bd7bcc477a3e3549d637ca
author AhmadDurrani579 <ahmaddurranitrg@gmail.com> Sun Feb 01 00:47:48 2026
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Sun Feb 01 11:43:32 2026
tree 287b6a29a89c5308f296ee3643f832055c8f433d
parent 5a4c2cc916e4d8fd84b330c13ddafa20b38b0cbb

data_channel_benchmark: fix signaling race via Connect/Start split

Fix signaling race condition in data_channel_benchmark tool.

Previously, the signaling stream was accessed concurrently by the main
thread and the gRPC thread, causing races.

This CL fixes the issue by: 1) Splitting the client initialization into
Connect() and Start(). 2) Connecting the stream *before* starting the
reading threads. 3) This ensures the stream is fully initialized before
use, removing the need for a Mutex. 4) Updating the benchmark client to
call Connect() before Start().

Bug: webrtc:474556968
Test: Verified locally; concurrent connections no longer race and client disconnections do not crash the server.
Change-Id: I985175dffee32044c104cde9fe9ac6f6a34ef162
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/434820
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#46787}