| commit | a10740239dd0f40f54d65288055e128496e2da3f | [log] [tgz] |
|---|---|---|
| author | kwiberg <kwiberg@webrtc.org> | Wed Jun 08 12:24:40 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Jun 08 12:24:47 2016 |
| tree | cf5e7cf9246ce46ae0f63aae5a7312295c9f0b25 | |
| parent | 271d74078894bb24f454eb31b77e4ce38097a2fa [diff] |
Fix UBSan errors (signed integer overflow) WebRtcSpl_CrossCorrelation and WebRtcSpl_DotProductWithScale compute the int32 sum of pairwise products from two int16 arrays. So as to avoid overflow (which could otherwise happen when as little as two products were summed), the products are right-shifted by an amount specified by the caller. This CL changes WebRtcIlbcfix_MyCorr and WebRtcIlbcfix_Smooth to give sufficient right-shift amounts, instead of ones that may be too small and cause overflow. BUG=chromium:601787 Review-Url: https://codereview.webrtc.org/2014033002 Cr-Commit-Position: refs/heads/master@{#13066}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.