Remove WebRTC.Video.Screenshare.NUmberResolutionDownswitchesPerMinute histogram
Bug: chromium:1138341
Change-Id: Ia9be1cf86d9a83bd17d2b80aa04f4297d6047159
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287061
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38845}
diff --git a/video/receive_statistics_proxy2_unittest.cc b/video/receive_statistics_proxy2_unittest.cc
index 5031cdf..f0869c4 100644
--- a/video/receive_statistics_proxy2_unittest.cc
+++ b/video/receive_statistics_proxy2_unittest.cc
@@ -1753,12 +1753,7 @@
statistics_proxy_->UpdateHistograms(absl::nullopt, StreamDataCounters(),
nullptr);
const int kExpectedDownscales = 30; // 2 per 4 seconds = 30 per minute.
- if (videocontenttypehelpers::IsScreenshare(content_type_)) {
- EXPECT_METRIC_EQ(
- kExpectedDownscales,
- metrics::MinSample("WebRTC.Video.Screenshare."
- "NumberResolutionDownswitchesPerMinute"));
- } else {
+ if (!videocontenttypehelpers::IsScreenshare(content_type_)) {
EXPECT_METRIC_EQ(kExpectedDownscales,
metrics::MinSample(
"WebRTC.Video.NumberResolutionDownswitchesPerMinute"));
diff --git a/video/video_quality_observer2.cc b/video/video_quality_observer2.cc
index 0751d3f..0afc2f5 100644
--- a/video/video_quality_observer2.cc
+++ b/video/video_quality_observer2.cc
@@ -109,11 +109,13 @@
int num_resolution_downgrades_per_minute =
num_resolution_downgrades_ * 60000 / video_duration_ms;
- RTC_HISTOGRAM_COUNTS_SPARSE_100(
- uma_prefix + ".NumberResolutionDownswitchesPerMinute",
- num_resolution_downgrades_per_minute);
- log_stream << uma_prefix << ".NumberResolutionDownswitchesPerMinute "
- << num_resolution_downgrades_per_minute << "\n";
+ if (!screenshare) {
+ RTC_HISTOGRAM_COUNTS_SPARSE_100(
+ uma_prefix + ".NumberResolutionDownswitchesPerMinute",
+ num_resolution_downgrades_per_minute);
+ log_stream << uma_prefix << ".NumberResolutionDownswitchesPerMinute "
+ << num_resolution_downgrades_per_minute << "\n";
+ }
int num_freezes_per_minute =
freezes_durations_.NumSamples() * 60000 / video_duration_ms;