commit | a857698d549df4977d38555af220e7839e484cfc | [log] [tgz] |
---|---|---|
author | Guido Urdaneta <guidou@webrtc.org> | Tue Apr 09 17:12:23 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Apr 09 17:12:33 2019 |
tree | 535a0072f86b233c1a4e41d63e5bd1fa39a351e9 | |
parent | 5154c5bc01ca3d6d7f380e30fa9c9c97917b4dee [diff] |
Revert "Adding a restriction for legal RID values." This reverts commit 07f3279a730980583403b78c3762c5d246d1d9be. Reason for revert: Suspect of producing consistent failure in some Chrome trybots, blocking rolls. Failed test: external/wpt/webrtc/RTCPeerConnection-addTransceiver.https.html First failure: https://ci.chromium.org/p/chromium/builders/try/linux-rel/64597 Original change's description: > Adding a restriction for legal RID values. > > According to the spec, RID values should be constrained to only > alpha-numeric values. This was not enforced in our implementation to > allow for more flexibility. > It has been brought to our attention that some values that we currently > consider legal (such as the '~', '=' ';' characters) might cause confusion > with the simulcast syntax that uses these characters to indicate other > meanings. > What's worse, is that some characters, when used in RIDs (such as > \u{1f937} \u{1f4a9} and \u{1f926}) cause uncontrollable laughter for some > users which might also be a health hazard. > This change resolves these issues by restricting RIDs to alpha-numeric. > > Bug: webrtc:10491 > Change-Id: I16e262c87525d0289764beacd098e1525a355463 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132061 > Reviewed-by: Steve Anton <steveanton@webrtc.org> > Commit-Queue: Amit Hilbuch <amithi@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27499} TBR=steveanton@webrtc.org,amithi@webrtc.org Change-Id: I89f9d8a8d3fa82de8a7d429f11ad7cc30812ba7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10491 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132244 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27525}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.