commit aaaeb29ef54828cce3f6aab4d718487640235ab5
author Harald Alvestrand <hta@webrtc.org> Thu Oct 31 13:49:39 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 31 15:31:38 2024
tree 1e926e1c0f0ac93e2a5f343db31fc161d15c87fb
parent 3fa21c89c0bbe112012d31e5441e18bedd7b2fd9

Allow single-argument StrCat

and modify DEPS files accordingly.
This is done in support of the decision to encourage AbslStringify.

Bug: None
Change-Id: I26fee77978d1dd21be6d2ef011c4dfd78a7b43e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367204
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43338}

DEPS

diff --git a/DEPS b/DEPS
index 62fa520..40366ea 100644
--- a/DEPS
+++ b/DEPS
@@ -2125,6 +2125,7 @@
   "+absl/strings/ascii.h",
   "+absl/strings/escaping.h",
   "+absl/strings/match.h",
+  "+absl/strings/str_cat.h",  # note - allowed for single argument version only
   "+absl/strings/str_replace.h",
   "+absl/strings/string_view.h",
   "+absl/types/variant.h",

api/DEPS

diff --git a/api/DEPS b/api/DEPS
index 93774f0..a034102 100644
--- a/api/DEPS
+++ b/api/DEPS
@@ -261,8 +261,4 @@
     "+video",
     "+third_party",
   ],
-
-  "jsep_unittest\.cc": [
-    "+absl/strings/str_cat.h",
-  ]
 }

g3doc/abseil-in-webrtc.md

diff --git a/g3doc/abseil-in-webrtc.md b/g3doc/abseil-in-webrtc.md
index 7798f24..66edbb8 100644
--- a/g3doc/abseil-in-webrtc.md
+++ b/g3doc/abseil-in-webrtc.md
@@ -44,6 +44,7 @@
 * The macros in `absl/base/attributes.h`, `absl/base/config.h` and
   `absl/base/macros.h`.
 * `absl/numeric/bits.h`
+* Single argument absl::StrCat
 
 * ABSL_FLAG is allowed in tests and tools, but disallowed in in non-test code.
 
@@ -78,3 +79,7 @@
 These are optimized for speed, not binary size. Even `StrCat` calls
 with a modest number of arguments can easily add several hundred bytes
 to the binary.
+
+Exception: Single-argument absl::StrCat is allowed in order to make it
+easy to use AbslStringify. See [TOTW #2015](https://abseil.io/tips/215) for
+details on AbslStringify.

media/DEPS

diff --git a/media/DEPS b/media/DEPS
index 12cad68..663bf7f 100644
--- a/media/DEPS
+++ b/media/DEPS
@@ -40,7 +40,4 @@
   ".*codec\.h": [
     "+absl/strings/str_format.h",
   ],
-  ".*codec_unittest\.cc": [
-    "+absl/strings/str_cat.h",
-  ],
 }

rtc_base/DEPS

diff --git a/rtc_base/DEPS b/rtc_base/DEPS
index a0ac9d6..a936a22 100644
--- a/rtc_base/DEPS
+++ b/rtc_base/DEPS
@@ -8,10 +8,6 @@
 specific_include_rules = {
   "checks.h": [
     "+absl/strings/has_absl_stringify.h",
-    "+absl/strings/str_cat.h",
-  ],
-  "string_encode.h": [
-    "+absl/strings/str_cat.h"
   ],
   "protobuf_utils.h": [
     "+third_party/protobuf",
@@ -27,7 +23,6 @@
   ],
   "logging.h": [
     "+absl/strings/has_absl_stringify.h",
-    "+absl/strings/str_cat.h",
   ],
   "trace_event\.h": [
     "+third_party/perfetto",