commit ab9395924c18aed2c5cfc114c06d153a1c2c68ae
author Tommi <tommi@webrtc.org> Fri Mar 15 13:03:27 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 18 09:47:18 2024
tree f2a43947689ca625816f5f35452f6c4da7b345c2
parent 5d3acb5195979ea086dba8ced269171e1f770898

Remove deprecated Port ctors and AddAddress

Bug: webrtc:15846
Change-Id: I7fafdefc0108c45d2865584aa01f44caa95ec36f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342521
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41915}

p2p/base/port.h

diff --git a/p2p/base/port.h b/p2p/base/port.h
index ff7ddf9..c0a3b56 100644
--- a/p2p/base/port.h
+++ b/p2p/base/port.h
@@ -193,46 +193,6 @@
        const webrtc::FieldTrialsView* field_trials = nullptr,
        bool shared_socket = false);
 
-  // // TODO: bugs.webrtc.org/15846 - Remove.
-  [[deprecated("Use IceCandidateType version")]] Port(
-      webrtc::TaskQueueBase* thread,
-      absl::string_view type ABSL_ATTRIBUTE_LIFETIME_BOUND,
-      rtc::PacketSocketFactory* factory,
-      const rtc::Network* network,
-      uint16_t min_port,
-      uint16_t max_port,
-      absl::string_view username_fragment,
-      absl::string_view password,
-      const webrtc::FieldTrialsView* field_trials = nullptr,
-      bool shared_socket = false)
-      : Port(thread,
-             PortTypeToIceCandidateType(type),
-             factory,
-             network,
-             min_port,
-             max_port,
-             username_fragment,
-             password,
-             field_trials,
-             shared_socket) {}
-
-  // // TODO: bugs.webrtc.org/15846 - Remove.
-  [[deprecated("Use IceCandidateType version")]] Port(
-      webrtc::TaskQueueBase* thread,
-      absl::string_view type ABSL_ATTRIBUTE_LIFETIME_BOUND,
-      rtc::PacketSocketFactory* factory,
-      const rtc::Network* network,
-      absl::string_view username_fragment,
-      absl::string_view password,
-      const webrtc::FieldTrialsView* field_trials = nullptr)
-      : Port(thread,
-             PortTypeToIceCandidateType(type),
-             factory,
-             network,
-             username_fragment,
-             password,
-             field_trials) {}
-
  public:
   ~Port() override;
 
@@ -419,24 +379,6 @@
 
   rtc::WeakPtr<Port> NewWeakPtr() { return weak_factory_.GetWeakPtr(); }
 
-  // TODO: bugs.webrtc.org/15846 - Remove.
-  [[deprecated("Use IceCandidateType version")]] void AddAddress(
-      const rtc::SocketAddress& address,
-      const rtc::SocketAddress& base_address,
-      const rtc::SocketAddress& related_address,
-      absl::string_view protocol,
-      absl::string_view relay_protocol,
-      absl::string_view tcptype,
-      absl::string_view type,
-      uint32_t type_preference,
-      uint32_t relay_preference,
-      absl::string_view url,
-      bool is_final) {
-    AddAddress(address, base_address, related_address, protocol, relay_protocol,
-               tcptype, PortTypeToIceCandidateType(type), type_preference,
-               relay_preference, url, is_final);
-  }
-
   void AddAddress(const rtc::SocketAddress& address,
                   const rtc::SocketAddress& base_address,
                   const rtc::SocketAddress& related_address,