commit | 73ee252245f1d8dec9a4ae0bc7fe2390d58b4fd7 | [log] [tgz] |
---|---|---|
author | Henrik Boström <hbos@webrtc.org> | Mon Jun 27 08:28:24 2022 |
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 27 09:37:31 2022 |
tree | 12d06dbea09b86b26fb381edeb1808a7c137dc76 | |
parent | fb698490bf066df9d05009097eab5dd9fc5bd8cc [diff] |
Remove excessive log spam from receiver.getParameters(). It's normal for a receiver to not be configured to receive, such as when currentDirection is not (or not yet) "sendrecv" or "recvonly". getParameters() returning an empty set of encodings is valid and these logs are not very useful. It's also inconsistent that we only log after SLD has happened due to different code paths inside getParameters(), repro: https://jsfiddle.net/henbos/xqksj3wd/. Most notably we're calling getParameters() internally from inside of getStats() which can cause excessive log spam. I prefer that we remove these logs rather than avoid calling getParameters() from inside of getStats() on non-receiving receivers since it's valid to check how many encodings exist on a receiver using getParameters(), and whether or not the SSRC has been signaled could in theory affect the number of encodings even if we do want to receive. Also an app calling getParameters() on an inactive receiver is valid and should not cause logs. Bug: webrtc:14225 Change-Id: I4290781d6aed92aa03fe0c662762aa97c99a045c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266960 Commit-Queue: Erik Språng <sprang@webrtc.org> Auto-Submit: Henrik Boström <hbos@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37335}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.